Build clang Debug if we build lldb debug.

[sas]

Summary

When we build Debug, we might be tracking down bugs in clang/llvm as
well, so building it Debug with assertions helps debug the debugger.

[sas]

Remove leftover comment.

[tfiala]

We have a separate configuration for that build in Xcode - it is called DebugClang. You can build that configuration from the command line with something like:

xcodebuild --scheme desktop --configuration DebugClang

or clone the "desktop" scheme in Xcode, setting the scheme build option to use the DebugClang configuration instead of the Debug configuration.

Generally we don't want to force building a debug llvm/clang by default in the default Debug configuration since it has a noticeable impact on test run time.

@clayborg, thoughts on that?

[clayborg]

As Todd said, we already have a "DebugClang" configuration for this. We should abandon this change.

[sas]

Ah, makes sense, I had missed the DebugClang build configuration. Thanks for pointing this out.

lldb.xcodeproj/project.pbxproj

1DEB91F008733DB70010E9CD /* Debug */ = {
         LLDB_ENABLE_COVERAGE = 0;
         LLDB_FRAMEWORK_INSTALL_DIR = /Applications/Xcode.app/Contents/SharedFrameworks;
         LLDB_TOOLS_INSTALL_DIR = /usr/bin;
         LLDB_ZLIB_CFLAGS = "-DHAVE_LIBZ=1";
         LLDB_ZLIB_LDFLAGS = "-lz";
         LLVM_BUILD_DIR = "$(SRCROOT)/llvm-build/$(LLVM_CONFIGURATION)";
         LLVM_BUILD_DIRTREE = "$(SRCROOT)/llvm-build";
         LLVM_BUILD_DIR_ARCH = "$(CURRENT_ARCH)/";
-        LLVM_CONFIGURATION = "Release+Asserts";
+        LLVM_CONFIGURATION = "Debug+Asserts";
         LLVM_SOURCE_DIR = "$(SRCROOT)/llvm";
         MACOSX_DEPLOYMENT_TARGET = 10.9;
         ONLY_ACTIVE_ARCH = YES;
         OTHER_CFLAGS = (
           "-Wparentheses",
           "$(LLDB_ZLIB_CFLAGS)",
           "$(LLDB_COMPRESSION_CFLAGS)",
           "$(LLDB_COVERAGE_CFLAGS)",

scripts/Xcode/build-llvm.py

def get_exe_linker_flags ():
     return get_common_linker_flags()
 
 def get_shared_linker_flags ():
     return get_common_linker_flags()
 
 def CMAKE_FLAGS ():
     return {
         "Debug": [
-            "-DCMAKE_BUILD_TYPE=RelWithDebInfo",
+            "-DCMAKE_BUILD_TYPE=Debug",
             "-DLLVM_ENABLE_ASSERTIONS=ON",
             ],
         "DebugClang": [
              "-DCMAKE_BUILD_TYPE=Debug",
              "-DLLVM_ENABLE_ASSERTIONS=ON",
              ],
         "Release": [
             "-DCMAKE_BUILD_TYPE=Release",
             "-DLLVM_ENABLE_ASSERTIONS=ON",
             ],
         "BuildAndIntegration": [
             "-DCMAKE_BUILD_TYPE=Release",
             "-DLLVM_ENABLE_ASSERTIONS=OFF",
             ],