This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Make bucket_count() greater-equal assertions portable.
ClosedPublic

Authored by STL_MSFT on Jul 8 2016, 12:31 PM.

Details

Summary

Make bucket_count() greater-equal assertions portable.

The Standard provides a guarantee here, but these assertions were going beyond that guarantee. These containers have 8 elements, so the bucket count is guaranteed to be at least 8, but may not be as large as 11 (and isn't in MSVC's implementation).

Diff Detail

Event Timeline

STL_MSFT updated this revision to Diff 63295.Jul 8 2016, 12:31 PM
STL_MSFT retitled this revision from to [libcxx] [test] Make bucket_count() greater-equal assertions portable..
STL_MSFT updated this object.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
EricWF accepted this revision.Jul 24 2016, 4:21 PM
EricWF edited edge metadata.
This revision is now accepted and ready to land.Jul 24 2016, 4:21 PM
EricWF closed this revision.Jul 24 2016, 4:24 PM

r276580.