This is an archive of the discontinued LLVM Phabricator instance.

Differential D21971

Explicitly export symbols from the sample analyzer plugin
ClosedPublic

Authored by john.brawn on Jul 4 2016, 6:35 AM.

Details

Reviewers
reames
chapuni
Ilod
• ehsan
Commits
rGa4403c970839: Explicitly export symbols from the sample analyzer plugin
rC274871: Explicitly export symbols from the sample analyzer plugin
rL274871: Explicitly export symbols from the sample analyzer plugin
Summary

This is done so that it will work when built using MSVC if LLVM_EXPORT_SYMBOLS_FOR_PLUGINS=ON.

Diff Detail

Repository
rL LLVM

Event Timeline

john.brawn updated this revision to Diff 62674.Jul 4 2016, 6:35 AM
john.brawn retitled this revision from to Explicitly export symbols from the sample analyzer plugin.
john.brawn updated this object.
john.brawn added reviewers: Ilod, chapuni, • ehsan, reames.
john.brawn set the repository for this revision to rL LLVM.
john.brawn mentioned this in D21385: Adjust Registry interface to not require plugins to export a registry.
john.brawn added a subscriber: cfe-commits.
Ilod edited edge metadata.Jul 8 2016, 5:24 AM

LGTM.

Do you known if there is any good reason Analyzer plugins aren't using the Registry system (thus forcing plugin writers to manually export the functions)?

Ilod accepted this revision.Jul 8 2016, 5:24 AM
Ilod edited edge metadata.
This revision is now accepted and ready to land.Jul 8 2016, 5:24 AM
john.brawn added a comment.Jul 8 2016, 9:04 AM

Do you known if there is any good reason Analyzer plugins aren't using the Registry system (thus forcing plugin writers to manually export the functions)?

Your guess is as good as mine.

Closed by commit rL274871: Explicitly export symbols from the sample analyzer plugin (authored by john.brawn). · Explain WhyJul 8 2016, 9:28 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
cfe/
trunk/
examples/
analyzer-plugin/
3 lines
2 lines

Diff 63248

cfe/trunk/examples/analyzer-plugin/CMakeLists.txt

add_llvm_loadable_module(SampleAnalyzerPlugin MainCallChecker.cpp) set(LLVM_EXPORTED_SYMBOL_FILE ${CMAKE_CURRENT_SOURCE_DIR}/SampleAnalyzerPlugin.exports)
add_llvm_loadable_module(SampleAnalyzerPlugin MainCallChecker.cpp PLUGIN_TOOL clang)
if(LLVM_ENABLE_PLUGINS AND (WIN32 OR CYGWIN)) if(LLVM_ENABLE_PLUGINS AND (WIN32 OR CYGWIN))
target_link_libraries(SampleAnalyzerPlugin PRIVATE target_link_libraries(SampleAnalyzerPlugin PRIVATE
clangAnalysis clangAnalysis
clangAST clangAST
clangStaticAnalyzerCore clangStaticAnalyzerCore
LLVMSupport LLVMSupport
) )
endif() endif()

cfe/trunk/examples/analyzer-plugin/SampleAnalyzerPlugin.exports

clang_registerCheckers
clang_analyzerAPIVersionString