This is an archive of the discontinued LLVM Phabricator instance.

Differential D21877

[libcxx] [test] is_swappable_include_order.pass.cpp was using a terse static_assert.
ClosedPublic

Authored by STL_MSFT on Jun 29 2016, 4:39 PM.

Details

Reviewers
mclow.lists
EricWF
Summary

is_swappable_include_order.pass.cpp was using a terse static_assert.

As before, this unnecessarily limits compatibility with MSVC and old versions of GCC.

Diff Detail

Event Timeline

STL_MSFT updated this revision to Diff 62310.Jun 29 2016, 4:39 PM
STL_MSFT retitled this revision from to [libcxx] [test] is_swappable_include_order.pass.cpp was using a terse static_assert..
STL_MSFT updated this object.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
EricWF accepted this revision.Jun 29 2016, 9:35 PM
EricWF edited edge metadata.
This revision is now accepted and ready to land.Jun 29 2016, 9:35 PM
EricWF closed this revision.Jun 29 2016, 9:36 PM

r274206.

Revision Contents

PathSize
test/
std/
utilities/
meta/
meta.unary/
meta.unary.prop/
2 lines

Diff 62310

test/std/utilities/meta/meta.unary/meta.unary.prop/is_swappable_include_order.pass.cpp

Show All 25 Lines
int main() int main()
{ {
// Use a builtin type so we don't get ADL lookup. // Use a builtin type so we don't get ADL lookup.
typedef double T[17][29]; typedef double T[17][29];
{ {
LIBCPP_STATIC_ASSERT(std::__is_swappable<T>::value, ""); LIBCPP_STATIC_ASSERT(std::__is_swappable<T>::value, "");
#if TEST_STD_VER > 14 #if TEST_STD_VER > 14
static_assert(std::is_swappable_v<T>); static_assert(std::is_swappable_v<T>, "");
#endif #endif
} }
{ {
T t1 = {}; T t1 = {};
T t2 = {}; T t2 = {};
std::iter_swap(t1, t2); std::iter_swap(t1, t2);
std::swap_ranges(t1, t1 + 17, t2); std::swap_ranges(t1, t1 + 17, t2);
} }
} }