This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] std::array's iterators aren't guaranteed to be pointers.
ClosedPublic

Authored by STL_MSFT on Jun 29 2016, 4:30 PM.

Details

Summary

std::array's iterators aren't guaranteed to be pointers.

Include test_macros.h and mark these static_asserts as libcxx-specific.

Diff Detail

Event Timeline

STL_MSFT updated this revision to Diff 62307.Jun 29 2016, 4:30 PM
STL_MSFT retitled this revision from to [libcxx] [test] std::array's iterators aren't guaranteed to be pointers..
STL_MSFT updated this object.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
EricWF accepted this revision.Jun 29 2016, 10:01 PM
EricWF edited edge metadata.

I committed a similar change in r274210. It changes the asserts to LIBCPP_STATIC_ASSERT but it also adds additional tests that the iterators provide the correct typedefs and tags.

This revision is now accepted and ready to land.Jun 29 2016, 10:01 PM
EricWF closed this revision.Jun 29 2016, 10:01 PM