This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Make move_noexcept.pass.cpp tests more portable.
ClosedPublic

Authored by STL_MSFT on Jun 24 2016, 6:36 PM.

Details

Summary

Make move_noexcept.pass.cpp tests more portable.

They were static_asserting that the following things are nothrow-move-constructible:

ordered/unordered associative containers
deque
forward_list
list
vector<bool>

The Standard doesn't mark these things as having noexcept move constructors, so the static_asserts should be marked as libc++ specific.

Additionally, two container adaptors were affected:

queue
stack

They're depicted in the Standard as having implicitly defined move ctors. These tests are using the default backing container, deque, so these static_asserts also need to be changed.

Diff Detail

Event Timeline

STL_MSFT updated this revision to Diff 61874.Jun 24 2016, 6:36 PM
STL_MSFT retitled this revision from to [libcxx] [test] Make move_noexcept.pass.cpp tests more portable..
STL_MSFT updated this object.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
EricWF requested changes to this revision.Jun 26 2016, 1:30 PM
EricWF edited edge metadata.

Please add the required "test_macros.h" includes.

This revision now requires changes to proceed.Jun 26 2016, 1:30 PM
STL_MSFT updated this revision to Diff 62002.Jun 27 2016, 12:16 PM
STL_MSFT edited edge metadata.

Test macros for the test macro throne!

EricWF accepted this revision.Jul 24 2016, 4:26 PM
EricWF edited edge metadata.
This revision is now accepted and ready to land.Jul 24 2016, 4:26 PM
EricWF closed this revision.Jul 24 2016, 4:28 PM

r276581.