This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Make default_noexcept.pass.cpp tests more portable.
ClosedPublic

Authored by STL_MSFT on Jun 24 2016, 6:35 PM.

Details

Summary

Make default_noexcept.pass.cpp tests more portable.

They were static_asserting that the following things are nothrow-default-constructible:

ordered/unordered associative containers
container adaptors
deque
forward_list
list
vector<bool>

The Standard doesn't mark these things as having noexcept default constructors, so the static_asserts should be marked as libc++ specific.

Diff Detail

Event Timeline

STL_MSFT updated this revision to Diff 61873.Jun 24 2016, 6:35 PM
STL_MSFT retitled this revision from to [libcxx] [test] Make default_noexcept.pass.cpp tests more portable..
STL_MSFT updated this object.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
EricWF accepted this revision.Jun 26 2016, 1:08 PM
EricWF edited edge metadata.

This is missing "test_macros.h" includes, but I'll add them before committing. I'm sure that we pick them up through another include path, but they should be direct includes.

This revision is now accepted and ready to land.Jun 26 2016, 1:08 PM
EricWF closed this revision.Jun 26 2016, 1:28 PM

r273823.