This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Make unord.hash/integral.pass.cpp portable.
ClosedPublic

Authored by STL_MSFT on Jun 21 2016, 5:54 PM.

Details

Summary

Make unord.hash/integral.pass.cpp portable.

This was assuming identity hashing, which is a non-Standard assumption. Guarding this with LIBCPP_ASSERT makes the test portable.

Also fixes MSVC warning C4805 "'==': unsafe mix of type '::size_t' and type 'bool' in operation".

Diff Detail

Event Timeline

STL_MSFT updated this revision to Diff 61476.Jun 21 2016, 5:54 PM
STL_MSFT retitled this revision from to [libcxx] [test] Make unord.hash/integral.pass.cpp portable..
STL_MSFT updated this object.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
EricWF accepted this revision.Jun 21 2016, 5:59 PM
EricWF edited edge metadata.
This revision is now accepted and ready to land.Jun 21 2016, 5:59 PM
EricWF closed this revision.Jun 21 2016, 6:01 PM

r273345.