[libcxxabi] Reorder base class initializers in libc++abi tests to prevent -Wreorder

[EricWF]

Summary

This patch fixes -Wreorder warnings on test classes with virtual bases. Since the compiler is performing the reordering anyway this change *should* have NFC.

However the test notes that it is checking that "virtual base classes work properly". Since initialization order is clearly part of correctness I want to confirm that this wasn't an intentional mistake.

[howard.hinnant]

Look good to me.

libcxxabi/trunk/test/catch_class_04.pass.cpp

 
 int C2::count = 0;
 
 struct A
     : C1, C2
 {
     static int count;
     int id_;
-    explicit A(int id) : C1(id-1), C2(id-2), B(id+3), id_(id) {count++;}
-    A(const A& a) : C1(a.id_-1), C2(a.id_-2), B(a.id_+3), id_(a.id_) {count++;}
+    explicit A(int id) : B(id+3), C1(id-1), C2(id-2), id_(id) {count++;}
+    A(const A& a) :  B(a.id_+3), C1(a.id_-1), C2(a.id_-2), id_(a.id_) {count++;}
     ~A() {count--;}
 };
 
 int A::count = 0;
 
 void f1()
 {
     assert(A::count == 0);

libcxxabi/trunk/test/catch_ptr.pass.cpp

 
 int C2::count = 0;
 
 struct A
     : C1, C2
 {
     static int count;
     int id_;
-    explicit A(int id) : C1(id-1), C2(id-2), B(id+3), id_(id) {count++;}
-    A(const A& a) : C1(a.id_-1), C2(a.id_-2), B(a.id_+3), id_(a.id_) {count++;}
+    explicit A(int id) : B(id+3), C1(id-1), C2(id-2), id_(id) {count++;}
+    A(const A& a) : B(a.id_+3), C1(a.id_-1), C2(a.id_-2),  id_(a.id_) {count++;}
     ~A() {count--;}
 };
 
 int A::count = 0;
 
 A a(5);
 
 void f1()