Page MenuHomePhabricator

[libcxxabi] Reorder base class initializers in libc++abi tests to prevent -Wreorder
ClosedPublic

Authored by EricWF on Jun 15 2016, 12:32 PM.

Details

Summary

This patch fixes -Wreorder warnings on test classes with virtual bases. Since the compiler is performing the reordering anyway this change *should* have NFC.

However the test notes that it is checking that "virtual base classes work properly". Since initialization order is clearly part of correctness I want to confirm that this wasn't an intentional mistake.

Diff Detail

Repository
rL LLVM

Event Timeline

EricWF updated this revision to Diff 60876.Jun 15 2016, 12:32 PM
EricWF retitled this revision from to [libcxxabi] Reorder base class initializers in libc++abi tests to prevent -Wreorder.
EricWF updated this object.
EricWF added reviewers: mclow.lists, howard.hinnant.
EricWF added a subscriber: cfe-commits.

Look good to me.

This revision was automatically updated to reflect the committed changes.