Addition of debugger comments & whitespace

[tlwilmar]

Summary

The removal of legacy code to support long-deprecated debugger support library resulted in some whitespace changes. Comments from that legacy code were made public as they may be useful for other debuggers.

Patch by Olga Malysheva.

[AndreyChurbanov]

LGTM

I think we could commit comments changes without review as they cannot break any build/execution tasks.

openmp/trunk/runtime/src/dllexports

%ifndef stub
     %endif
 
 
     %ifdef USE_DEBUGGER
         __kmp_debugging                         DATA
         __kmp_omp_debug_struct_info             DATA
     %endif
 
-        # Symbols for MS mutual detection:
-        _You_must_link_with_exactly_one_OpenMP_library    DATA
-        _You_must_link_with_Intel_OpenMP_library          DATA
-        %ifdef msvc_compat
-            _You_must_link_with_Microsoft_OpenMP_library  DATA
-        %endif
 
-        __kmp_wait_64
-        __kmp_release_64
 
 
 #    VT_getthid                              1
 #    vtgthid                                 2
 
     __kmpc_atomic_4                         100
     __kmpc_atomic_8                         101
     __kmpc_atomic_fixed4_add                102

openmp/trunk/runtime/src/kmp_runtime.c

 static void __kmp_init_allocator() {}
 static void __kmp_fini_allocator() {}
 
 /* ------------------------------------------------------------------------ */
 
 #ifdef KMP_DYNAMIC_LIB
 # if KMP_OS_WINDOWS
 
-
 static void
 __kmp_reset_lock( kmp_bootstrap_lock_t* lck ) {
     // TODO: Change to __kmp_break_bootstrap_lock().
     __kmp_init_bootstrap_lock( lck ); // make the lock released
 }
 
 static void
 __kmp_reset_locks_on_process_detach( int gtid_req ) {

openmp/trunk/runtime/src/kmp_tasking.c

#if OMPT_SUPPORT && OMPT_TRACE
             taskdata->ompt_task_info.frame.reenter_runtime_frame = __builtin_frame_address(0);
             if (ompt_callbacks.ompt_callback(ompt_event_taskwait_begin)) {
                 ompt_callbacks.ompt_callback(ompt_event_taskwait_begin)(
                                 my_parallel_id, my_task_id);
             }
         }
 #endif
 
+        // Debugger: The taskwait is active. Store location and thread encountered the taskwait.
 #if USE_ITT_BUILD
         // Note: These values are used by ITT events as well.
 #endif /* USE_ITT_BUILD */
         taskdata->td_taskwait_counter += 1;
         taskdata->td_taskwait_ident    = loc_ref;
         taskdata->td_taskwait_thread   = gtid + 1;
 
 #if USE_ITT_BUILD
#endif
             }
         }
 #if USE_ITT_BUILD
         if ( itt_sync_obj != NULL )
             __kmp_itt_taskwait_finished( gtid, itt_sync_obj );
 #endif /* USE_ITT_BUILD */
 
         // GEH TODO: shouldn't we have some sort of OMPRAP API calls here to mark end of wait?
+        // Debugger:  The taskwait is completed. Location remains, but thread is negated.
         taskdata->td_taskwait_thread = - taskdata->td_taskwait_thread;
 
 #if OMPT_SUPPORT && OMPT_TRACE
         if (ompt_enabled) {
             if (ompt_callbacks.ompt_callback(ompt_event_taskwait_end)) {
                 ompt_callbacks.ompt_callback(ompt_event_taskwait_end)(
                                 my_parallel_id, my_task_id);
             }
KA_TRACE(10, ("__kmpc_omp_taskyield(enter): T#%d loc=%p end_part = %d\n",
                   gtid, loc_ref, end_part) );
 
     if ( __kmp_tasking_mode != tskm_immediate_exec && __kmp_init_parallel ) {
         // GEH TODO: shouldn't we have some sort of OMPRAP API calls here to mark begin wait?
 
         thread = __kmp_threads[ gtid ];
         taskdata = thread -> th.th_current_task;
         // Should we model this as a task wait or not?
+        // Debugger: The taskwait is active. Store location and thread encountered the taskwait.
 #if USE_ITT_BUILD
         // Note: These values are used by ITT events as well.
 #endif /* USE_ITT_BUILD */
         taskdata->td_taskwait_counter += 1;
         taskdata->td_taskwait_ident    = loc_ref;
         taskdata->td_taskwait_thread   = gtid + 1;
 
 #if USE_ITT_BUILD
#endif /* USE_ITT_BUILD */
             }
         }
 #if USE_ITT_BUILD
         if ( itt_sync_obj != NULL )
             __kmp_itt_taskwait_finished( gtid, itt_sync_obj );
 #endif /* USE_ITT_BUILD */
 
         // GEH TODO: shouldn't we have some sort of OMPRAP API calls here to mark end of wait?
+        // Debugger:  The taskwait is completed. Location remains, but thread is negated.
         taskdata->td_taskwait_thread = - taskdata->td_taskwait_thread;
     }
 
     KA_TRACE(10, ("__kmpc_omp_taskyield(exit): T#%d task %p resuming, "
                   "returning TASK_CURRENT_NOT_QUEUED\n", gtid, taskdata) );
 
     return TASK_CURRENT_NOT_QUEUED;
 }