This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Avoid C++17 terse static_assert.
ClosedPublic

Authored by STL_MSFT on Jun 14 2016, 2:25 PM.

Details

Summary

TOTALLY OPTIONAL, feel free to reject this, I won't mind.

Newly-added libcxx tests for C++17 features have been using C++17 terse static_asserts occasionally. This is problematic for MSVC at the moment, since the compiler doesn't yet support the terse form. Changing the tests to always use the original recipe static_assert instead of extra crispy allows them to pass when we have the corresponding library support.

MSVC will be gaining support for the terse form soon, which will make this a non-issue for me, but I wanted to send out this change just in case you thought it was a worthwhile improvement in consistency.

Diff Detail

Event Timeline

STL_MSFT updated this revision to Diff 60754.Jun 14 2016, 2:25 PM
STL_MSFT retitled this revision from to [libcxx] [test] Avoid C++17 terse static_assert..
STL_MSFT updated this object.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
EricWF accepted this revision.Jun 21 2016, 6:13 PM
EricWF edited edge metadata.

I'm really happy to accept this patch. I was trying to run some of these tests against GCC 5.3 last week and it didn't support this form of static assert yet.
I'm secretly sad that we have to roll it back though :-( It's so much nicer.

This revision is now accepted and ready to land.Jun 21 2016, 6:13 PM
EricWF closed this revision.Jun 21 2016, 6:17 PM

r273353.