This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Improve portability of vector tests.
ClosedPublic

Authored by STL_MSFT on Jun 14 2016, 2:20 PM.

Details

Summary

Improve portability of vector tests.

This test was assuming libcxx's 2x growth factor, which isn't guaranteed by the Standard and isn't provided by MSVC (we use 1.5x). As a result the exact capacity check fails. Marking the assertion as libcxx-specific is all we need, and allows the rest of the test to succeed.

Diff Detail

Event Timeline

STL_MSFT updated this revision to Diff 60752.Jun 14 2016, 2:20 PM
STL_MSFT retitled this revision from to [libcxx] [test] Improve portability of vector tests..
STL_MSFT updated this object.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
EricWF accepted this revision.Jun 14 2016, 6:50 PM
EricWF edited edge metadata.
This revision is now accepted and ready to land.Jun 14 2016, 6:50 PM
EricWF closed this revision.Jun 14 2016, 6:51 PM

r272745.