This is an archive of the discontinued LLVM Phabricator instance.

Differential D21342

[esan|cfrag] Add the struct field size array in StructInfo
ClosedPublic

Authored by zhaoqin on Jun 14 2016, 1:57 PM.

Details

Reviewers
aizatsky
Commits
rGe24bc365e848: [esan|cfrag] Add the struct field size array in StructInfo
rCRT272988: [esan|cfrag] Add the struct field size array in StructInfo
rL272988: [esan|cfrag] Add the struct field size array in StructInfo
Summary

Adds the struct field size array in the struct StructInfo.

Prints struct field size info in the report.

Diff Detail

Repository
rL LLVM

Event Timeline

zhaoqin updated this revision to Diff 60743.Jun 14 2016, 1:57 PM
zhaoqin retitled this revision from to [esan|cfrag] Add the struct field size array in StructInfo.
zhaoqin updated this object.
zhaoqin added a reviewer: aizatsky.
zhaoqin added subscribers: llvm-commits, bruening, eugenis and 3 others.
Herald added a subscriber: kubamracek. · View Herald TranscriptJun 14 2016, 1:57 PM
aizatsky accepted this revision.Jun 16 2016, 4:09 PM
aizatsky edited edge metadata.
This revision is now accepted and ready to land.Jun 16 2016, 4:09 PM
Closed by commit rL272988: [esan|cfrag] Add the struct field size array in StructInfo (authored by zhaoqin). · Explain WhyJun 16 2016, 9:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
compiler-rt/
trunk/
lib/
esan/
7 lines
test/
esan/
TestCases/
32 lines

Diff 61064

compiler-rt/trunk/lib/esan/cache_frag.cpp

Show All 23 Lines
//===-- Struct field access counter runtime -------------------------------===// //===-- Struct field access counter runtime -------------------------------===//
// This should be kept consistent with LLVM's EfficiencySanitizer StructInfo. // This should be kept consistent with LLVM's EfficiencySanitizer StructInfo.
struct StructInfo { struct StructInfo {
const char *StructName; const char *StructName;
u32 Size; u32 Size;
u32 NumFields; u32 NumFields;
u32 *FieldOffsets; u32 *FieldOffsets;
u32 *FieldSize;
u64 *FieldCounters; u64 *FieldCounters;
const char **FieldTypeNames; const char **FieldTypeNames;
}; };
// This should be kept consistent with LLVM's EfficiencySanitizer CacheFragInfo. // This should be kept consistent with LLVM's EfficiencySanitizer CacheFragInfo.
// The tool-specific information per compilation unit (module). // The tool-specific information per compilation unit (module).
struct CacheFragInfo { struct CacheFragInfo {
const char *UnitName; const char *UnitName;
▲ Show 20 Lines • Show All 53 Lines • ▼ Show 20 Linesstatic void reportStructCounter(StructHashMap::Handle &Handle) {
} }
// Remove the suffixes with '#' during print. // Remove the suffixes with '#' during print.
end = strchr(start, '#'); end = strchr(start, '#');
CHECK(end != nullptr); CHECK(end != nullptr);
Report(" %s %.*s\n", type, end - start, start); Report(" %s %.*s\n", type, end - start, start);
Report(" size = %u, count = %llu, ratio = %llu\n", Struct->Size, Report(" size = %u, count = %llu, ratio = %llu\n", Struct->Size,
Handle->Count, Handle->Ratio); Handle->Count, Handle->Ratio);
for (u32 i = 0; i < Struct->NumFields; ++i) { for (u32 i = 0; i < Struct->NumFields; ++i) {
Report(" #%2u: offset = %u,\t count = %llu,\t type = %.*s\n", i, Report(" #%2u: offset = %u,\t size = %u,\t count = %llu,\t type = %.*s\n",
Struct->FieldOffsets[i], Struct->FieldCounters[i], i, Struct->FieldOffsets[i], Struct->FieldSize[i],
TypePrintLimit, Struct->FieldTypeNames[i]); Struct->FieldCounters[i], TypePrintLimit, Struct->FieldTypeNames[i]);
} }
} }
static void computeStructRatio(StructHashMap::Handle &Handle) { static void computeStructRatio(StructHashMap::Handle &Handle) {
Handle->Ratio = 0; Handle->Ratio = 0;
Handle->Count = Handle->Struct->FieldCounters[0]; Handle->Count = Handle->Struct->FieldCounters[0];
for (u32 i = 1; i < Handle->Struct->NumFields; ++i) { for (u32 i = 1; i < Handle->Struct->NumFields; ++i) {
Handle->Count += Handle->Struct->FieldCounters[i]; Handle->Count += Handle->Struct->FieldCounters[i];
▲ Show 20 Lines • Show All 81 Lines • Show Last 20 Lines

compiler-rt/trunk/test/esan/TestCases/struct-simple.cpp

Show First 20 Lines • Show All 137 Lines • ▼ Show 20 Linesint main(int argc, char **argv) {
return 0; return 0;
// CHECK: in esan::finalizeLibrary // CHECK: in esan::finalizeLibrary
// CHECK-NEXT: in esan::finalizeCacheFrag // CHECK-NEXT: in esan::finalizeCacheFrag
// CHECK-NEXT: in esan::processCompilationUnitExit // CHECK-NEXT: in esan::processCompilationUnitExit
// CHECK-NEXT: in esan::processCacheFragCompilationUnitExit: {{.*}}struct-simple.cpp with 5 class(es)/struct(s) // CHECK-NEXT: in esan::processCacheFragCompilationUnitExit: {{.*}}struct-simple.cpp with 5 class(es)/struct(s)
// CHECK-NEXT: Unregister class.C#3#14#13#13: 3 fields // CHECK-NEXT: Unregister class.C#3#14#13#13: 3 fields
// CHECK-NEXT: {{.*}} class C // CHECK-NEXT: {{.*}} class C
// CHECK-NEXT: {{.*}} size = 32, count = 5, ratio = 3 // CHECK-NEXT: {{.*}} size = 32, count = 5, ratio = 3
// CHECK-NEXT: {{.*}} # 0: offset = 0, count = 2, type = %struct.anon = type { i32, i32 } // CHECK-NEXT: {{.*}} # 0: offset = 0, size = 8, count = 2, type = %struct.anon = type { i32, i32 }
// CHECK-NEXT: {{.*}} # 1: offset = 8, count = 2, type = %union.anon = type { double } // CHECK-NEXT: {{.*}} # 1: offset = 8, size = 8, count = 2, type = %union.anon = type { double }
// CHECK-NEXT: {{.*}} # 2: offset = 16, count = 1, type = [10 x i8] // CHECK-NEXT: {{.*}} # 2: offset = 16, size = 10, count = 1, type = [10 x i8]
// CHECK-NEXT: Unregister struct.anon#2#11#11: 2 fields // CHECK-NEXT: Unregister struct.anon#2#11#11: 2 fields
// CHECK-NEXT: {{.*}} struct anon // CHECK-NEXT: {{.*}} struct anon
// CHECK-NEXT: {{.*}} size = 8, count = 2, ratio = 1 // CHECK-NEXT: {{.*}} size = 8, count = 2, ratio = 1
// CHECK-NEXT: {{.*}} # 0: offset = 0, count = 1, type = i32 // CHECK-NEXT: {{.*}} # 0: offset = 0, size = 4, count = 1, type = i32
// CHECK-NEXT: {{.*}} # 1: offset = 4, count = 1, type = i32 // CHECK-NEXT: {{.*}} # 1: offset = 4, size = 4, count = 1, type = i32
// CHECK-NEXT: Unregister union.anon#1#3: 1 fields // CHECK-NEXT: Unregister union.anon#1#3: 1 fields
// CHECK-NEXT: Unregister struct.S#2#11#11: 2 fields // CHECK-NEXT: Unregister struct.S#2#11#11: 2 fields
// CHECK-NEXT: {{.*}} struct S // CHECK-NEXT: {{.*}} struct S
// CHECK-NEXT: {{.*}} size = 8, count = 2, ratio = 2 // CHECK-NEXT: {{.*}} size = 8, count = 2, ratio = 2
// CHECK-NEXT: {{.*}} # 0: offset = 0, count = 2, type = i32 // CHECK-NEXT: {{.*}} # 0: offset = 0, size = 4, count = 2, type = i32
// CHECK-NEXT: {{.*}} # 1: offset = 4, count = 0, type = i32 // CHECK-NEXT: {{.*}} # 1: offset = 4, size = 4, count = 0, type = i32
// CHECK-NEXT: Unregister struct.D#3#11#11#11: 3 fields // CHECK-NEXT: Unregister struct.D#3#11#11#11: 3 fields
// CHECK-NEXT: {{.*}} struct D // CHECK-NEXT: {{.*}} struct D
// CHECK-NEXT: {{.*}} size = 12, count = 2, ratio = 2 // CHECK-NEXT: {{.*}} size = 12, count = 2, ratio = 2
// CHECK-NEXT: {{.*}} # 0: offset = 0, count = 1, type = i32 // CHECK-NEXT: {{.*}} # 0: offset = 0, size = 4, count = 1, type = i32
// CHECK-NEXT: {{.*}} # 1: offset = 4, count = 1, type = i32 // CHECK-NEXT: {{.*}} # 1: offset = 4, size = 4, count = 1, type = i32
// CHECK-NEXT: {{.*}} # 2: offset = 8, count = 0, type = i32 // CHECK-NEXT: {{.*}} # 2: offset = 8, size = 4, count = 0, type = i32
// CHECK-NEXT: in esan::processCompilationUnitExit // CHECK-NEXT: in esan::processCompilationUnitExit
// CHECK-NEXT: in esan::processCacheFragCompilationUnitExit: {{.*}}struct-simple.cpp with 0 class(es)/struct(s) // CHECK-NEXT: in esan::processCacheFragCompilationUnitExit: {{.*}}struct-simple.cpp with 0 class(es)/struct(s)
// CHECK-NEXT: in esan::processCompilationUnitExit // CHECK-NEXT: in esan::processCompilationUnitExit
// CHECK-NEXT: in esan::processCacheFragCompilationUnitExit: {{.*}}struct-simple.cpp with 5 class(es)/struct(s) // CHECK-NEXT: in esan::processCacheFragCompilationUnitExit: {{.*}}struct-simple.cpp with 5 class(es)/struct(s)
// CHECK-NEXT: Unregister struct.A#2#11#11: 2 fields // CHECK-NEXT: Unregister struct.A#2#11#11: 2 fields
// CHECK-NEXT: {{.*}} struct A // CHECK-NEXT: {{.*}} struct A
// CHECK-NEXT: {{.*}} size = 8, count = 2049, ratio = 2048 // CHECK-NEXT: {{.*}} size = 8, count = 2049, ratio = 2048
// CHECK-NEXT: {{.*}} # 0: offset = 0, count = 2048, type = i32 // CHECK-NEXT: {{.*}} # 0: offset = 0, size = 4, count = 2048, type = i32
// CHECK-NEXT: {{.*}} # 1: offset = 4, count = 1, type = i32 // CHECK-NEXT: {{.*}} # 1: offset = 4, size = 4, count = 1, type = i32
// CHECK-NEXT: Unregister struct.B#2#3#2: 2 fields // CHECK-NEXT: Unregister struct.B#2#3#2: 2 fields
// CHECK-NEXT: {{.*}} struct B // CHECK-NEXT: {{.*}} struct B
// CHECK-NEXT: {{.*}} size = 16, count = 2097153, ratio = 2097152 // CHECK-NEXT: {{.*}} size = 16, count = 2097153, ratio = 2097152
// CHECK-NEXT: {{.*}} # 0: offset = 0, count = 1, type = float // CHECK-NEXT: {{.*}} # 0: offset = 0, size = 4, count = 1, type = float
// CHECK-NEXT: {{.*}} # 1: offset = 8, count = 2097152, type = double // CHECK-NEXT: {{.*}} # 1: offset = 8, size = 8, count = 2097152, type = double
// CHECK-NEXT: Unregister union.U#1#3: 1 fields // CHECK-NEXT: Unregister union.U#1#3: 1 fields
// CHECK-NEXT: Duplicated struct.S#2#11#11: 2 fields // CHECK-NEXT: Duplicated struct.S#2#11#11: 2 fields
// CHECK-NEXT: Unregister struct.D#2#11#11: 2 fields // CHECK-NEXT: Unregister struct.D#2#11#11: 2 fields
// CHECK-NEXT: {{.*}} struct D // CHECK-NEXT: {{.*}} struct D
// CHECK-NEXT: {{.*}} size = 8, count = 1, ratio = 1 // CHECK-NEXT: {{.*}} size = 8, count = 1, ratio = 1
// CHECK-NEXT: {{.*}} # 0: offset = 0, count = 1, type = i32 // CHECK-NEXT: {{.*}} # 0: offset = 0, size = 4, count = 1, type = i32
// CHECK-NEXT: {{.*}} # 1: offset = 4, count = 0, type = i32 // CHECK-NEXT: {{.*}} # 1: offset = 4, size = 4, count = 0, type = i32
// CHECK-NEXT: {{.*}}EfficiencySanitizer: total struct field access count = 2099214 // CHECK-NEXT: {{.*}}EfficiencySanitizer: total struct field access count = 2099214
} }
#endif // MAIN #endif // MAIN