This is an archive of the discontinued LLVM Phabricator instance.

Bug fixes in lock code.
AbandonedPublic

Authored by tlwilmar on Jun 13 2016, 1:26 PM.

Details

Reviewers
hbae
Summary

(Parts of this change were already applied to LLVM code base.)

This change set fixes two bugs in the lock code.

  1. Misplaced switch target in the __kmp_get_user_lock_owner function found by LLVM user
  2. Use of incorrect time-stamp counter in the __kmp_spin_backoff function for non-Intel architecture, found by Jim

A new utility function kmp_now_nsec() was added for the second item,
and code for handling wrap-around counters (provided by Jim) was also
added for the
kmp_spin_backoff function.

Patch by Hansang Bae

Diff Detail

Repository
rL LLVM

Event Timeline

tlwilmar updated this revision to Diff 60594.Jun 13 2016, 1:26 PM
tlwilmar retitled this revision from to Bug fixes in lock code..
tlwilmar updated this object.
tlwilmar added a reviewer: hbae.
tlwilmar set the repository for this revision to rL LLVM.
tlwilmar added a subscriber: openmp-commits.
tlwilmar abandoned this revision.Jun 13 2016, 2:12 PM