Bug fix for 26602: Remove function bodies with KMP_ASSERT(0)

[tlwilmar]

Summary

Fix for bugzilla https://llvm.org/bugs/show_bug.cgi?id=26602.
Removed functions body consisted of the only KMP_ASSERT(0) statement.
Thus possible runtime crash converted to compile-time error, which
looks preferable (faster possible error detection).

TODO: consider C++11 static assert as an alternative, that could
make the diagnostics better.

Patch by Andrey Churbanov

[jlpeyton]

LGTM

openmp/trunk/runtime/src/kmp_dispatch.cpp

 /* ------------------------------------------------------------------------ */
 /* ------------------------------------------------------------------------ */
 
 #undef USE_TEST_LOCKS
 
 // test_then_add template (general template should NOT be used)
 template< typename T >
 static __forceinline T
-test_then_add( volatile T *p, T d ) { KMP_ASSERT(0); };
+test_then_add( volatile T *p, T d );
 
 template<>
 __forceinline kmp_int32
 test_then_add< kmp_int32 >( volatile kmp_int32 *p, kmp_int32 d )
 {
     kmp_int32 r;
     r = KMP_TEST_THEN_ADD32( p, d );
     return r;
 }
 
 template<>
 __forceinline kmp_int64
 test_then_add< kmp_int64 >( volatile kmp_int64 *p, kmp_int64 d )
 {
     kmp_int64 r;
     r = KMP_TEST_THEN_ADD64( p, d );
     return r;
 }
 
 // test_then_inc_acq template (general template should NOT be used)
 template< typename T >
 static __forceinline T
-test_then_inc_acq( volatile T *p ) { KMP_ASSERT(0); };
+test_then_inc_acq( volatile T *p );
 
 template<>
 __forceinline kmp_int32
 test_then_inc_acq< kmp_int32 >( volatile kmp_int32 *p )
 {
     kmp_int32 r;
     r = KMP_TEST_THEN_INC_ACQ32( p );
     return r;
 }
 
 template<>
 __forceinline kmp_int64
 test_then_inc_acq< kmp_int64 >( volatile kmp_int64 *p )
 {
     kmp_int64 r;
     r = KMP_TEST_THEN_INC_ACQ64( p );
     return r;
 }
 
 // test_then_inc template (general template should NOT be used)
 template< typename T >
 static __forceinline T
-test_then_inc( volatile T *p ) { KMP_ASSERT(0); };
+test_then_inc( volatile T *p );
 
 template<>
 __forceinline kmp_int32
 test_then_inc< kmp_int32 >( volatile kmp_int32 *p )
 {
     kmp_int32 r;
     r = KMP_TEST_THEN_INC32( p );
     return r;
 }
 
 template<>
 __forceinline kmp_int64
 test_then_inc< kmp_int64 >( volatile kmp_int64 *p )
 {
     kmp_int64 r;
     r = KMP_TEST_THEN_INC64( p );
     return r;
 }
 
 // compare_and_swap template (general template should NOT be used)
 template< typename T >
 static __forceinline kmp_int32
-compare_and_swap( volatile T *p, T c, T s ) { KMP_ASSERT(0); };
+compare_and_swap( volatile T *p, T c, T s );
 
 template<>
 __forceinline kmp_int32
 compare_and_swap< kmp_int32 >( volatile kmp_int32 *p, kmp_int32 c, kmp_int32 s )
 {
     return KMP_COMPARE_AND_STORE_REL32( p, c, s );
 }