clang-rename: implement handling of remaining named casts

[vmiklos]

Summary

const_cast<> and reinterpret_cast<>.

[klimek]

LG, although I believe the recent history of changes indicates that the approach is suboptimal, and we should address this on a higher level. But for now fixing the bugs seems like the right short-term approach.

[vmiklos]

Yes, if there will be a way to avoid hooking into each and every AST callback, that sounds more effective. :-) I'm aware of one more bug around destructors when renaming a class, but then I'm (as a user) quite happy about the current state.

clang-tools-extra/trunk/clang-rename/USRLocFinder.cpp

public:
   bool VisitCXXStaticCastExpr(clang::CXXStaticCastExpr *Expr) {
     return handleCXXNamedCastExpr(Expr);
   }
 
   bool VisitCXXDynamicCastExpr(clang::CXXDynamicCastExpr *Expr) {
     return handleCXXNamedCastExpr(Expr);
   }
 
+  bool VisitCXXReinterpretCastExpr(clang::CXXReinterpretCastExpr *Expr) {
+    return handleCXXNamedCastExpr(Expr);
+  }
+
+  bool VisitCXXConstCastExpr(clang::CXXConstCastExpr *Expr) {
+    return handleCXXNamedCastExpr(Expr);
+  }
+
   // Non-visitors:
 
   // \brief Returns a list of unique locations. Duplicate or overlapping
   // locations are erroneous and should be reported!
   const std::vector<clang::SourceLocation> &getLocationsFound() const {
     return LocationsFound;
   }
 

clang-tools-extra/trunk/test/clang-rename/ConstCastExpr.cpp

+// RUN: cat %s > %t.cpp
+// RUN: clang-rename -offset=133 -new-name=X %t.cpp -i --
+// RUN: sed 's,//.*,,' %t.cpp | FileCheck %s
+class Cla {
+public:
+  int getValue() {
+    return 0;
+  }
+};
+
+int main() {
+  const Cla *C = new Cla();
+  const_cast<Cla *>(C)->getValue(); // CHECK: const_cast<X *>
+}
+
+// Use grep -FUbo 'Cla' <file> to get the correct offset of foo when changing
+// this file.

clang-tools-extra/trunk/test/clang-rename/ReinterpretCastExpr.cpp

+// RUN: cat %s > %t.cpp
+// RUN: clang-rename -offset=133 -new-name=X %t.cpp -i --
+// RUN: sed 's,//.*,,' %t.cpp | FileCheck %s
+class Cla {
+public:
+  int getValue() const {
+    return 0;
+  }
+};
+
+int main() {
+  void *C = new Cla();
+  reinterpret_cast<const Cla *>(C)->getValue(); // CHECK: reinterpret_cast<const X *>
+}
+
+// Use grep -FUbo 'Cla' <file> to get the correct offset of foo when changing
+// this file.