This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Fix MSVC warning C4125 "decimal digit terminates octal escape sequence".
ClosedPublic

Authored by STL_MSFT on Jun 7 2016, 12:32 PM.

Details

Summary

Fix MSVC warning C4125 "decimal digit terminates octal escape sequence".

MSVC somewhat justifiably warns when it sees an octal escape immediately followed by a decimal digit, even if the octal escape used the maximum of 3 octal digits. Avoiding this warning while preserving the test's semantics (as viewed by the library) is easy - simply separate the string literal after the octal escape is finished.

Diff Detail

Event Timeline

STL_MSFT updated this revision to Diff 59936.Jun 7 2016, 12:32 PM
STL_MSFT retitled this revision from to [libcxx] [test] Fix MSVC warning C4125 "decimal digit terminates octal escape sequence"..
STL_MSFT updated this object.
STL_MSFT added reviewers: mclow.lists, EricWF.
STL_MSFT added a subscriber: cfe-commits.
EricWF accepted this revision.Jun 13 2016, 10:53 PM
EricWF edited edge metadata.

I'm not a fan of the warning, but it seems like a minimally invasive fix.

This revision is now accepted and ready to land.Jun 13 2016, 10:53 PM
EricWF closed this revision.Jun 13 2016, 10:54 PM

r272639.