This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Rename global "x" to "testcases" in complex.number/cases.h and make it const for safety.
ClosedPublic

Authored by STL_MSFT on Jun 2 2016, 9:48 AM.

Details

Summary

Rename global "x" to "testcases" in complex.number/cases.h and make it const for safety.

Fixes MSVC warning C4459 "declaration of 'x' hides global declaration".

NOTE: As the addition of const is a semantic change, please double-check that the tests are passing. With MSVC I observe that this fixes the compiler warnings, but I still have unrelated runtime failures.

Diff Detail

Event Timeline

STL_MSFT updated this revision to Diff 59407.Jun 2 2016, 9:48 AM
STL_MSFT retitled this revision from to [libcxx] [test] Rename global "x" to "testcases" in complex.number/cases.h and make it const for safety..
STL_MSFT updated this object.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
mclow.lists accepted this revision.Jun 6 2016, 11:30 AM
mclow.lists edited edge metadata.

Landed as revision 271919

This revision is now accepted and ready to land.Jun 6 2016, 11:30 AM
STL_MSFT closed this revision.Jun 7 2016, 12:14 PM

Marshall checked this in, so I'm closing this.