This is an archive of the discontinued LLVM Phabricator instance.

Automatically detect export lists for OS X.
ClosedPublic

Authored by EricWF on May 28 2016, 12:03 PM.

Details

Summary

Libc++ reexports symbols from the system libc++abi using -reexport_symbols_list. This can cause a linker failure if the list contains symbols not defined in the system libc++abi.
This patch attempts to detect the OS X version and use it to determine the correct symbol list.

It's my understanding that lib/libc++abi2.exp should be used on 10.9 and greater. Otherwise 'lib/libc++abi.exp' should be used

This fixes PR25666 (https://llvm.org/bugs/show_bug.cgi?id=25666)

Diff Detail

Event Timeline

EricWF updated this revision to Diff 58897.May 28 2016, 12:03 PM
EricWF retitled this revision from to Automatically detect export lists for OS X..
EricWF updated this object.
EricWF added reviewers: mclow.lists, bcraig, dexonsmith.
EricWF added a subscriber: cfe-commits.
EricWF accepted this revision.Jun 14 2016, 11:50 AM
EricWF added a reviewer: EricWF.

Accepting to commit.

This revision is now accepted and ready to land.Jun 14 2016, 11:50 AM
EricWF closed this revision.Jun 14 2016, 3:01 PM