This is an archive of the discontinued LLVM Phabricator instance.

Differential D20747

[esan] Add support for log_exe_name
ClosedPublic

Authored by bruening on May 27 2016, 1:03 PM.

Details

Reviewers
zhaoqin
aizatsky
Commits
rG0b04950116d9: [esan] Add support for log_exe_name
rCRT271586: [esan] Add support for log_exe_name
rL271586: [esan] Add support for log_exe_name
Summary

Adds the call needed to cache the binary name to support the sanitizer
option log_exe_name for usable log file results when running multiple
applications. Adds a test.

Diff Detail

Repository
rL LLVM

Event Timeline

bruening updated this revision to Diff 58827.May 27 2016, 1:03 PM
bruening retitled this revision from to [esan] Add support for log_exe_name.
bruening updated this object.
bruening added a reviewer: aizatsky.
bruening added subscribers: llvm-commits, eugenis, kcc and 2 others.
Herald added a subscriber: kubamracek. · View Herald TranscriptMay 27 2016, 1:03 PM
bruening added a reviewer: zhaoqin.Jun 2 2016, 11:34 AM
zhaoqin accepted this revision.Jun 2 2016, 11:50 AM
zhaoqin edited edge metadata.

LGTM

This revision is now accepted and ready to land.Jun 2 2016, 11:50 AM
aizatsky accepted this revision.Jun 2 2016, 1:20 PM
aizatsky edited edge metadata.
Closed by commit rL271586: [esan] Add support for log_exe_name (authored by bruening). · Explain WhyJun 2 2016, 1:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
compiler-rt/
trunk/
lib/
esan/
1 line
test/
esan/
TestCases/
4 lines

Diff 59452

compiler-rt/trunk/lib/esan/esan.cpp

Show First 20 Lines • Show All 175 Lines • ▼ Show 20 Lines
void initializeLibrary(ToolType Tool) { void initializeLibrary(ToolType Tool) {
// We assume there is only one thread during init. // We assume there is only one thread during init.
if (EsanIsInitialized) { if (EsanIsInitialized) {
CHECK(Tool == WhichTool); CHECK(Tool == WhichTool);
return; return;
} }
WhichTool = Tool; WhichTool = Tool;
SanitizerToolName = "EfficiencySanitizer"; SanitizerToolName = "EfficiencySanitizer";
CacheBinaryName();
initializeFlags(); initializeFlags();
// Intercepting libc _exit or exit via COMMON_INTERCEPTOR_ON_EXIT only // Intercepting libc _exit or exit via COMMON_INTERCEPTOR_ON_EXIT only
// finalizes on an explicit exit call by the app. To handle a normal // finalizes on an explicit exit call by the app. To handle a normal
// exit we register an atexit handler. // exit we register an atexit handler.
::__cxa_atexit((void (*)())finalizeLibrary); ::__cxa_atexit((void (*)())finalizeLibrary);
VPrintf(1, "in esan::%s\n", __FUNCTION__); VPrintf(1, "in esan::%s\n", __FUNCTION__);
▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines

compiler-rt/trunk/test/esan/TestCases/verbose-simple.c

// RUN: %clang_esan_frag -O0 %s -o %t 2>&1 // RUN: %clang_esan_frag -O0 %s -o %t 2>&1
// RUN: %env_esan_opts=verbosity=1 %run %t 2>&1 | FileCheck %s // RUN: %env_esan_opts="verbosity=1 log_exe_name=1" %run %t 2>&1 | FileCheck %s
int main(int argc, char **argv) { int main(int argc, char **argv) {
// CHECK: in esan::initializeLibrary // CHECK: in esan::initializeLibrary
// (There can be a re-exec for stack limit here.) // (There can be a re-exec for stack limit here.)
// CHECK: Shadow scale=2 offset=0x440000000000 // CHECK: Shadow scale=2 offset=0x440000000000
// CHECK-NEXT: Shadow #0: [110000000000-114000000000) (256GB) // CHECK-NEXT: Shadow #0: [110000000000-114000000000) (256GB)
// CHECK-NEXT: Shadow #1: [124000000000-12c000000000) (512GB) // CHECK-NEXT: Shadow #1: [124000000000-12c000000000) (512GB)
// CHECK-NEXT: Shadow #2: [148000000000-150000000000) (512GB) // CHECK-NEXT: Shadow #2: [148000000000-150000000000) (512GB)
// CHECK-NEXT: in esan::finalizeLibrary // CHECK-NEXT: in esan::finalizeLibrary
// CHECK-NEXT: {{.*}}EfficiencySanitizer is not finished: nothing yet to report // CHECK-NEXT: ==verbose-simple{{.*}}EfficiencySanitizer is not finished: nothing yet to report
return 0; return 0;
} }