This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] Prefer UNSUPPORTED over conditional compilation for tests
ClosedPublic

Authored by rmaprath on May 27 2016, 7:41 AM.

Details

Summary

We seem to have quite a few tests where an entire test is conditionalized over some range of _LIBCPP_STD_VER. We should consider getting rid of these and using the UNSUPPORTED lit directive instead.

This is mostly cosmetic, but sometimes can create problems if there are also XFAIL conditions on the same test. The test will be reported as an unexpected-pass when run with a std= option not compatible with the _LIBCPP_STD_VER check (because the test is trivially empty, it will pass rather than XFAIL).

I've attached a sample patch for one of the cases. If this looks OK, I can commit the whole hog.

Diff Detail

Repository
rL LLVM

Event Timeline

rmaprath updated this revision to Diff 58781.May 27 2016, 7:41 AM
rmaprath retitled this revision from to [libcxx] Prefer UNSUPPORTED over conditional compilation for tests.
rmaprath updated this object.
rmaprath added a reviewer: EricWF.
rmaprath added a subscriber: cfe-commits.

LGTM. Add @mclow.lists as a reviewer.

EricWF accepted this revision.May 27 2016, 10:21 AM
EricWF edited edge metadata.
This revision is now accepted and ready to land.May 27 2016, 10:21 AM
mclow.lists accepted this revision.May 27 2016, 9:51 PM
mclow.lists added a reviewer: mclow.lists.

LGTM.

This revision was automatically updated to reflect the committed changes.