This is an archive of the discontinued LLVM Phabricator instance.

Differential D20640

[AMDGPU] Set default dwarf version to 2
ClosedPublic

Authored by kzhuravl on May 25 2016, 1:01 PM.

Details

Reviewers
• tstellarAMD
Commits
rG81fbadb63f4d: [AMDGPU] Set default dwarf version to 2
rC271347: [AMDGPU] Set default dwarf version to 2
rL271347: [AMDGPU] Set default dwarf version to 2

Diff Detail

Repository
rL LLVM

Event Timeline

kzhuravl updated this revision to Diff 58481.May 25 2016, 1:01 PM
kzhuravl retitled this revision from to [AMDGPU] Set default dwarf version to 2.
kzhuravl updated this object.
kzhuravl added a reviewer: • tstellarAMD.
kzhuravl added a subscriber: cfe-commits.
Herald added a subscriber: kzhuravl. · View Herald TranscriptMay 25 2016, 1:01 PM
• tstellarAMD accepted this revision.May 27 2016, 4:51 PM
• tstellarAMD edited edge metadata.

LGTM.

This revision is now accepted and ready to land.May 27 2016, 4:51 PM
Closed by commit rL271347: [AMDGPU] Set default dwarf version to 2 (authored by kzhuravl). · Explain WhyMay 31 2016, 3:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
cfe/
trunk/
lib/
Driver/
1 line
test/
Driver/
3 lines

Diff 59144

cfe/trunk/lib/Driver/ToolChains.h

Show First 20 Lines • Show All 937 Lines • ▼ Show 20 Lines
class LLVM_LIBRARY_VISIBILITY AMDGPUToolChain : public Generic_ELF { class LLVM_LIBRARY_VISIBILITY AMDGPUToolChain : public Generic_ELF {
protected: protected:
Tool *buildLinker() const override; Tool *buildLinker() const override;
public: public:
AMDGPUToolChain(const Driver &D, const llvm::Triple &Triple, AMDGPUToolChain(const Driver &D, const llvm::Triple &Triple,
const llvm::opt::ArgList &Args); const llvm::opt::ArgList &Args);
unsigned GetDefaultDwarfVersion() const override { return 2; }
bool IsIntegratedAssemblerDefault() const override { return true; } bool IsIntegratedAssemblerDefault() const override { return true; }
}; };
class LLVM_LIBRARY_VISIBILITY NaClToolChain : public Generic_ELF { class LLVM_LIBRARY_VISIBILITY NaClToolChain : public Generic_ELF {
public: public:
NaClToolChain(const Driver &D, const llvm::Triple &Triple, NaClToolChain(const Driver &D, const llvm::Triple &Triple,
const llvm::opt::ArgList &Args); const llvm::opt::ArgList &Args);
▲ Show 20 Lines • Show All 244 Lines • Show Last 20 Lines

cfe/trunk/test/Driver/amdgpu-toolchain.c

// RUN: %clang -### -target amdgcn--amdhsa -x assembler -mcpu=kaveri %s 2>&1 | FileCheck -check-prefix=AS_LINK %s // RUN: %clang -### -target amdgcn--amdhsa -x assembler -mcpu=kaveri %s 2>&1 | FileCheck -check-prefix=AS_LINK %s
// AS_LINK: clang{{.*}} "-cc1as" // AS_LINK: clang{{.*}} "-cc1as"
// AS_LINK: ld.lld{{.*}} "-shared" // AS_LINK: ld.lld{{.*}} "-shared"
// RUN: %clang -### -g -target amdgcn--amdhsa -mcpu=kaveri %s 2>&1 | FileCheck -check-prefix=DWARF_VER %s
// DWARF_VER: "-dwarf-version=2"