This is an archive of the discontinued LLVM Phabricator instance.

[libcxxabi] Allow explicit pthread opt-in
ClosedPublic

Authored by bcraig on May 24 2016, 9:58 AM.

Details

Summary

Companion to http://reviews.llvm.org/D20573

When building libcxxabi in tree (i.e. in llvm/projects/libcxxabi, along with llvm/projects/libcxx), libcxx's config_site.in doesn't get created in a timely manner. This means that any configuration that is normally set in libcxx's config_site.in needs to be duplicated in libcxxabi to successfully build libcxxabi. This patch does exactly that for the _LIBCPP_HAS_THREAD_API_PTHREAD preprocessor define.

Diff Detail

Event Timeline

bcraig updated this revision to Diff 58257.May 24 2016, 9:58 AM
bcraig retitled this revision from to [libcxxabi] Allow explicit pthread opt-in.
bcraig updated this object.
bcraig added reviewers: rmaprath, mclow.lists, EricWF.
bcraig added a subscriber: cfe-commits.
rmaprath added inline comments.May 24 2016, 11:28 AM
CMakeLists.txt
278

Shouldn't there be an option() line for this new build option? Also a check for compatibility with the LIBCXXABI_ENABLE_THREADS option?

bcraig updated this revision to Diff 58317.May 24 2016, 2:16 PM
bcraig marked an inline comment as done.
rmaprath accepted this revision.May 24 2016, 11:07 PM
rmaprath edited edge metadata.

LGTM.

(I don't have powers to accept libcxx patches in general, but this patch is quite small and related to something I plugged in, so, I think it's OK in this instance)

This revision is now accepted and ready to land.May 24 2016, 11:07 PM
bcraig closed this revision.May 25 2016, 11:02 AM

r270732