Page MenuHomePhabricator

Allow unit testing on Windows
ClosedPublic

Authored by jlpeyton on May 18 2016, 3:27 PM.

Details

Summary

These changes allows testing on Windows with clang.exe. There are two main changes:

  1. only include -lm when it actually exists on the system
  2. create basic versions of pthread_create() and pthread_join() for windows. They are not POSIX compliant by any stretch but will allow any existing (and future) tests to use pthread_create() and pthread_join() for testing interactions of libomp with os threads.

Diff Detail

Repository
rL LLVM

Event Timeline

jlpeyton updated this revision to Diff 57685.May 18 2016, 3:27 PM
jlpeyton retitled this revision from to Allow unit testing on Windows.
jlpeyton updated this object.
jlpeyton added reviewers: jcownie, tlwilmar.
jlpeyton set the repository for this revision to rL LLVM.
jlpeyton added a subscriber: openmp-commits.
tlwilmar accepted this revision.May 20 2016, 2:37 PM
tlwilmar edited edge metadata.

LGTM

This revision is now accepted and ready to land.May 20 2016, 2:37 PM
This revision was automatically updated to reflect the committed changes.