clang-rename: when renaming a field, rename initializers of that field as well

[vmiklos]

Summary

The second check failed, the initializer wasn't renamed.

[klimek]

test/clang-rename/FieldTest.cpp

7–9 ↗

(On Diff #56241)

Any reason you put the run lines down there, btw? Usually we put them at the top :)

[vmiklos]

Not really, I just copied VarTest.cpp. I'll put it to top for new tests.

clang-tools-extra/trunk/clang-rename/USRLocFinder.cpp

if (RecordDecl) {
       if (getUSRForDecl(RecordDecl) == USR) {
         // The declaration refers to a type that is to be renamed.
         LocationsFound.push_back(Decl->getTypeSpecStartLoc());
       }
     }
     return true;
   }
 
+  bool VisitCXXConstructorDecl(clang::CXXConstructorDecl *ConstructorDecl) {
+    for (clang::CXXConstructorDecl::init_const_iterator it = ConstructorDecl->init_begin(); it != ConstructorDecl->init_end(); ++it) {
+      const clang::CXXCtorInitializer* Initializer = *it;
+      if (const clang::FieldDecl *FieldDecl = Initializer->getAnyMember()) {
+        if (getUSRForDecl(FieldDecl) == USR) {
+          // The initializer refers to a field that is to be renamed.
+          LocationsFound.push_back(Initializer->getSourceLocation());
+        }
+      }
+    }
+    return true;
+  }
+
   // Expression visitors:
 
   bool VisitDeclRefExpr(const DeclRefExpr *Expr) {
     const auto *Decl = Expr->getFoundDecl();
 
     checkNestedNameSpecifierLoc(Expr->getQualifierLoc());
     if (getUSRForDecl(Decl) == USR) {
       LocationsFound.push_back(Expr->getLocation());

clang-tools-extra/trunk/test/clang-rename/FieldTest.cpp

+class Cla
+{
+  int foo; // CHECK: hector;
+public:
+  Cla();
+};
+// RUN: cat %s > %t.cpp
+// RUN: clang-rename -offset=18 -new-name=hector %t.cpp -i --
+// RUN: sed 's,//.*,,' %t.cpp | FileCheck %s
+
+Cla::Cla()
+  : foo(0) // CHECK: hector(0)
+{
+}
+
+// Use grep -FUbo 'foo' <file> to get the correct offset of foo when changing
+// this file.