This is an archive of the discontinued LLVM Phabricator instance.

Differential D19726

[mips][FastISel] A store is not a load.
ClosedPublic

Authored by sdardis on Apr 29 2016, 8:52 AM.

Download Raw Diff

Details

Reviewers

dsanders
vkalintiris
mcrosier

Summary

Correct trivial error. One of the failing tests from PR/27458.

Diff Detail

Event Timeline

sdardis updated this revision to Diff 55607.Apr 29 2016, 8:52 AM

sdardis retitled this revision from to [mips][FastISel] A store is not a load..

sdardis updated this object.

sdardis added a reviewer: dsanders.

sdardis set the repository for this revision to rL LLVM.

sdardis added a subscriber: llvm-commits.

Herald added a reviewer: vkalintiris. · View Herald TranscriptApr 29 2016, 8:52 AM

Herald added subscribers: sdardis, dsanders. · View Herald Transcript

Pretty obvious. LGTM.

This revision is now accepted and ready to land.Apr 29 2016, 8:55 AM

Thanks, Committed as rL268053.

Revision Contents

Path

Size

lib/

Target/

Mips/

MipsFastISel.cpp

2 lines

test/

CodeGen/

Mips/

Fast-ISel/

2 lines

Diff 55607

lib/Target/Mips/MipsFastISel.cpp

	Show First 20 Lines • Show All 797 Lines • ▼ Show 20 Lines		if (Addr.isRegBase()) {
	return true;			return true;
	}			}
	if (Addr.isFIBase()) {			if (Addr.isFIBase()) {
	unsigned FI = Addr.getFI();			unsigned FI = Addr.getFI();
	unsigned Align = 4;			unsigned Align = 4;
	unsigned Offset = Addr.getOffset();			unsigned Offset = Addr.getOffset();
	MachineFrameInfo &MFI = *MF->getFrameInfo();			MachineFrameInfo &MFI = *MF->getFrameInfo();
	MachineMemOperand *MMO = MF->getMachineMemOperand(			MachineMemOperand *MMO = MF->getMachineMemOperand(
	MachinePointerInfo::getFixedStack(*MF, FI), MachineMemOperand::MOLoad,			MachinePointerInfo::getFixedStack(*MF, FI), MachineMemOperand::MOStore,
	MFI.getObjectSize(FI), Align);			MFI.getObjectSize(FI), Align);
	BuildMI(*FuncInfo.MBB, FuncInfo.InsertPt, DbgLoc, TII.get(Opc))			BuildMI(*FuncInfo.MBB, FuncInfo.InsertPt, DbgLoc, TII.get(Opc))
	.addReg(SrcReg)			.addReg(SrcReg)
	.addFrameIndex(FI)			.addFrameIndex(FI)
	.addImm(Offset)			.addImm(Offset)
	.addMemOperand(MMO);			.addMemOperand(MMO);
	return true;			return true;
	}			}
	▲ Show 20 Lines • Show All 1,072 Lines • Show Last 20 Lines

test/CodeGen/Mips/Fast-ISel/fastalloca.ll

	; RUN: llc -march=mipsel -relocation-model=pic -O0 -fast-isel-abort=1 -mcpu=mips32r2 \			; RUN: llc -march=mipsel -relocation-model=pic -O0 -fast-isel-abort=1 -mcpu=mips32r2 \
	; RUN: < %s \| FileCheck %s			; RUN: < %s -verify-machineinstrs \| FileCheck %s

	%struct.x = type { i32 }			%struct.x = type { i32 }

	@i = common global i32 0, align 4			@i = common global i32 0, align 4

	define i32 @foobar(i32 signext %x) {			define i32 @foobar(i32 signext %x) {
	entry:			entry:
	; CHECK-LABEL: foobar:			; CHECK-LABEL: foobar:
	Show All 22 Lines