[libcxx] [test] nasty_mutex::operator& should return nullptr, like nasty_list above it.

[STL_MSFT]

Summary

[libcxx] [test] nasty_mutex::operator& should return nullptr, like nasty_list above it.

Fixes MSVC "error C4716: 'nasty_mutex::operator&': must return a value".

[EricWF]

Well arguable it should be no return or even better it should have an "= delete" so it's diagnosed even if it's not called.

For now this works though.

[EricWF]

r267961.

[STL_MSFT]

[Eric Fiselier]

Well arguable it should be no return or even better it should
have an "= delete" so it's diagnosed even if it's not called.
For now this works though.

Agreed - I just wasn't sure what this code was trying to do, and I figured it should be consistent. I'm trying to keep my patches minimally intrusive until I understand your tests better.

Thanks,
STL

test/support/nasty_containers.hpp

 
 // Not really a mutex, but can play one in tests
 class nasty_mutex
 {
 public:
      nasty_mutex() _NOEXCEPT {}
      ~nasty_mutex() {}
 
-  nasty_mutex *operator& ()   { assert(false); }
+  nasty_mutex *operator& ()   { assert(false); return nullptr; }
   template <typename T>
   void operator, (const T &) { assert(false); }
 
 private:
     nasty_mutex(const nasty_mutex&)            { assert(false); }
     nasty_mutex& operator=(const nasty_mutex&) { assert(false); return *this; }
 
 public: