This is an archive of the discontinued LLVM Phabricator instance.

Tune basic block annotation algorithm.
ClosedPublic

Authored by danielcdh on Apr 19 2016, 4:57 PM.

Details

Summary

Instead of using maximum IR weight as the basic block weight, this patch uses the voting algorithm to find the most likely weight for the basic block. This can effectively avoid the cases when some IRs are annotated incorrectly due to code motion of the profiled binary.

This patch also updates propagate.ll unittest to include discriminator in the input file so that it is testing something meaningful.

Diff Detail

Event Timeline

danielcdh updated this revision to Diff 54294.Apr 19 2016, 4:57 PM
danielcdh retitled this revision from to Tune basic block annotation algorithm..
danielcdh updated this object.
danielcdh added reviewers: dnovillo, davidxl.
danielcdh added a subscriber: llvm-commits.
dnovillo accepted this revision.Apr 25 2016, 6:33 AM
dnovillo edited edge metadata.

LGTM. Apologies for the delay.

Thanks.

This revision is now accepted and ready to land.Apr 25 2016, 6:33 AM
danielcdh closed this revision.Apr 25 2016, 10:04 PM