This is an archive of the discontinued LLVM Phabricator instance.

[Clang][AVX512][BuiltIn] Adding support to intrinsics of VPERMD and VPERMW instruction set
ClosedPublic

Authored by m_zuckerman on Apr 17 2016, 2:15 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

m_zuckerman retitled this revision from to [Clang][AVX512][BuiltIn] Adding suppot to builtin for VPERMD and VPERMW instruction set .
m_zuckerman updated this object.
m_zuckerman added reviewers: AsafBadouh, igorb, delena.
m_zuckerman added a subscriber: llvm-commits.
AsafBadouh added inline comments.Apr 17 2016, 3:39 AM
lib/Headers/avx512fintrin.h
5642 ↗(On Diff #54000)

can you use _mm512_undefined_epi32() ?

5699 ↗(On Diff #54000)

can you use _mm512_undefined_epi32() ?

5754 ↗(On Diff #54000)

can you use _mm512_undefined_epi32() ?

lib/Headers/avx512vlintrin.h
7849 ↗(On Diff #54000)

the following are missing
_mm256_permutexvar_epi64,
_mm256_permutex_epi64,
_mm256_permutexvar_ps
_mm256_permutexvar_epi32

m_zuckerman marked 3 inline comments as done.
AsafBadouh added inline comments.Apr 18 2016, 1:22 AM
lib/Headers/avx512bwintrin.h
2065 ↗(On Diff #54002)

can you use _mm512_undefined_epi32() ?

lib/Headers/avx512vbmiintrin.h
87 ↗(On Diff #54002)

can you use _mm512_undefined_epi32() ?

lib/Headers/avx512vlbwintrin.h
3180 ↗(On Diff #54002)

_mm_undefined_si128() will work here?

3208 ↗(On Diff #54002)

_mm256_undefined_si256()

lib/Headers/avx512vlintrin.h
7803 ↗(On Diff #54002)

_mm256_undefined_si256()

7812 ↗(On Diff #54002)

_mm256_undefined_si256()

7849 ↗(On Diff #54002)

_mm256_undefined_si256()

7887 ↗(On Diff #54002)

_mm256_undefined_si256()

7915 ↗(On Diff #54002)

_mm256_undefined_si256()

m_zuckerman marked 3 inline comments as done.
m_zuckerman marked 7 inline comments as done.
AsafBadouh accepted this revision.Apr 24 2016, 4:20 AM
AsafBadouh edited edge metadata.

LGTM

This revision is now accepted and ready to land.Apr 24 2016, 4:20 AM
m_zuckerman retitled this revision from [Clang][AVX512][BuiltIn] Adding suppot to builtin for VPERMD and VPERMW instruction set to [Clang][AVX512][BuiltIn] Adding support to intrinsics of VPERMD and VPERMW instruction set .Apr 24 2016, 10:37 PM
m_zuckerman edited edge metadata.
This revision was automatically updated to reflect the committed changes.