The patch implements microMIPSr6 LL, SC, MOVEP, ROTR, ROTRV and SYSCALL instructions and add tests for LWM32 and SWM32.
Details
Diff Detail
- Repository
- rL LLVM
Event Timeline
Minor nits. When adding to the */(in)valid.s test files can you integrate the new instructions in alphabetical order with existing instructions? Also, group instructions of a similar size.
I know the files themselves aren't wholly consistent with this, so it doesn't have to be perfect.
lib/Target/Mips/Mips32r6InstrInfo.td | ||
---|---|---|
792–799 ↗ | (On Diff #53850) | Join these blocks together. |
test/MC/Disassembler/Mips/micromips32r6/valid.txt | ||
279–289 ↗ | (On Diff #53850) | As these are not ASE or floating point specific microMIPS instructions, can you place them between lines 31-100 in alphabetical order? It's more consistent that way. The movep should be placed in one of the 16 bit instruction blocks. |
test/MC/Disassembler/Mips/micromips64r6/valid.txt | ||
218–228 ↗ | (On Diff #53850) | Here too, just place these instructions with the 32bit instructions? move should be with the 16bit instructions. |
test/MC/Mips/micromips32r6/invalid.s | ||
136 ↗ | (On Diff #53850) | Can you add rotrv with an immediate operand here, syscall with a register operand, syscall with an out of range immediate? Finally please place the instructions in alphabetical order with the existing instructions depending on whether their are 32bit or 16bit long. |
test/MC/Mips/micromips32r6/valid.s | ||
278–299 ↗ | (On Diff #53850) | Try to integrate these into the first 100~ lines alphabetically. |
Rebased to work with TOT.
All tests (valid.s/valid.txt/invalid.s) sorted in alphabetical order.
Added invalid test for rotrv with an immediate operand.
Invalid tests for syscall with a register operand and syscall with an out of range immediate placed in invalid-wrong-error.s because they currently emit wrong error messages.
Sorry, I should have been clearer, when I said "place the instructions in alphabetical order", I mean the instructions you were adding, not the entire test file.
Just place the new tests at the bottom of the test files. Then submit the tests from this diff (54357) as two separate review requests, one containing the invalid/invalid-wrong-error/valid files, and the other with the disassembly tests.
Secondly, you've added tests for swm32 and lwm32. If that's all you're doing can you update the commit message + title to reflect that?
Thanks.