This is an archive of the discontinued LLVM Phabricator instance.

[Clang][Avx512][BuiltIn] Adding brodcast builtin to clang
ClosedPublic

Authored by m_zuckerman on Apr 12 2016, 5:24 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

m_zuckerman retitled this revision from to [Clang][Avx512][BuiltIn] Adding brodcast builtin to clang.
m_zuckerman updated this object.
m_zuckerman added reviewers: AsafBadouh, igorb, delena.
m_zuckerman added a subscriber: llvm-commits.
igorb added inline comments.Apr 12 2016, 6:00 AM
include/clang/Basic/BuiltinsX86.def
1981 ↗(On Diff #53386)

it should be "avx512bw" ?

lib/Headers/avx512bwintrin.h
2065 ↗(On Diff #53386)

could you please put casting on the same line with argument

m_zuckerman marked an inline comment as done.
m_zuckerman marked an inline comment as done.Apr 12 2016, 10:02 PM
igorb added inline comments.Apr 12 2016, 10:34 PM
lib/Headers/avx512bwintrin.h
2080 ↗(On Diff #53393)

could you please put casting on the same line with argument ( the same regarding the code below)

igorb added inline comments.Apr 13 2016, 2:01 AM
lib/Headers/avx512dqintrin.h
788 ↗(On Diff #53521)

could you please put casting on the same line with argument

827 ↗(On Diff #53521)

could you please put casting on the same line with argument ( the same regarding the code below)

865 ↗(On Diff #53521)

could you please put casting on the same line with argument

901 ↗(On Diff #53521)

could you please put casting on the same line with argument

lib/Headers/avx512vldqintrin.h
978 ↗(On Diff #53521)

could you please put casting on the same line with argument ( the same regarding the code below)

igorb accepted this revision.Apr 13 2016, 2:14 AM
igorb edited edge metadata.

Thanks!

LGTM

This revision is now accepted and ready to land.Apr 13 2016, 2:14 AM
This revision was automatically updated to reflect the committed changes.