This is an archive of the discontinued LLVM Phabricator instance.

[Clang][AVX512][BuiltIn] Adding avx512 ( psll{d|q}512,psllv{16si|8di},psra{d|q}512,psrav{16si|8di},pternlog{d|q}{128|256|512} ) builtin to clang ...
ClosedPublic

Authored by m_zuckerman on Apr 9 2016, 7:54 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

m_zuckerman updated this revision to Diff 53127.Apr 9 2016, 7:54 AM
m_zuckerman retitled this revision from to [Clang][AVX512][BuiltIn] Adding avx512 ( psll{d|q}512,psllv{16si|8di},psra{d|q}512,psrav{16si|8di},pternlog{d|q}{128|256|512} ) builtin to clang ....
m_zuckerman updated this object.
m_zuckerman added reviewers: AsafBadouh, delena, igorb.
m_zuckerman added a subscriber: llvm-commits.
AsafBadouh edited edge metadata.Apr 10 2016, 4:54 AM

there are duplication in the headers and in the tests.

lib/Headers/avx512fintrin.h
4345 ↗(On Diff #53127)

duplication

lib/Headers/avx512vlintrin.h
6408 ↗(On Diff #53127)

I think this definition is identical to line 6416

6446 ↗(On Diff #53127)

same

test/CodeGen/avx512f-builtins.c
2812 ↗(On Diff #53127)

same tests (line 2807 and 2813)

2836 ↗(On Diff #53127)

same tests (line 2831 and 2837)

test/CodeGen/avx512vl-builtins.c
4316 ↗(On Diff #53127)

same tests

4340 ↗(On Diff #53127)

same

4364 ↗(On Diff #53127)

same

4389 ↗(On Diff #53127)

duplication till the EOF

m_zuckerman edited edge metadata.
m_zuckerman marked 6 inline comments as done.

there are some tests duplication

test/CodeGen/avx512vl-builtins.c
4611 ↗(On Diff #53214)

duplicate
part of avx512f tests

AsafBadouh accepted this revision.Apr 11 2016, 8:18 AM
AsafBadouh edited edge metadata.

LGTM

This revision is now accepted and ready to land.Apr 11 2016, 8:18 AM
This revision was automatically updated to reflect the committed changes.