This is an archive of the discontinued LLVM Phabricator instance.

[BlockPlacement] Remove an unnecessary continue. NFC
ClosedPublic

Authored by haicheng on Apr 5 2016, 6:56 AM.

Reviewers

Summary

continue is at the bottom of the loop.

haicheng retitled this revision from to [BlockPlacement] Remove an unnecessary continue. NFC.

haicheng updated this object.

haicheng set the repository for this revision to rL LLVM.

haicheng added a subscriber: llvm-commits.

LGTM.

This revision is now accepted and ready to land.Apr 5 2016, 8:07 AM

Committed in r265407.

Path

Size

lib/

CodeGen/

1 line

Show First 20 Lines • Show All 805 Lines • ▼ Show 20 Lines	for (MachineBasicBlock *Succ : MBB->successors()) {
ExitingBB = MBB;		ExitingBB = MBB;
}		}
}		}

if (!HasLoopingSucc) {		if (!HasLoopingSucc) {
// Restore the old exiting state, no viable looping successor was found.		// Restore the old exiting state, no viable looping successor was found.
ExitingBB = OldExitingBB;		ExitingBB = OldExitingBB;
BestExitEdgeFreq = OldBestExitEdgeFreq;		BestExitEdgeFreq = OldBestExitEdgeFreq;
continue;
}		}
}		}
// Without a candidate exiting block or with only a single block in the		// Without a candidate exiting block or with only a single block in the
// loop, just use the loop header to layout the loop.		// loop, just use the loop header to layout the loop.
if (!ExitingBB \|\| L.getNumBlocks() == 1)		if (!ExitingBB \|\| L.getNumBlocks() == 1)
return nullptr;		return nullptr;

// Also, if we have exit blocks which lead to outer loops but didn't select		// Also, if we have exit blocks which lead to outer loops but didn't select
▲ Show 20 Lines • Show All 662 Lines • Show Last 20 Lines