The only difference between the removed tests and the pre-existing
ones, is the materialization of the zero constant, which shouldn't
matter for these cases.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
LGTM. Agreed, tests with a fixed zero operand are not useful in this case.
Some pre-existing labels are nit worthy though, I've highlighted them inline.
test/CodeGen/Mips/llvm-ir/srem.ll | ||
---|---|---|
187 ↗ | (On Diff #52356) | Shouldn't this be 64R6? |
test/CodeGen/Mips/llvm-ir/urem.ll | ||
215 ↗ | (On Diff #52356) | I know you haven't changed this, but shouldn't this be 64R6? |