This patch applies Duncan's work on hash_table to tree.
Details
Diff Detail
Event Timeline
This looks good to me, except for the noisy tests.
test/std/containers/associative/set/insert_and_emplace_allocator_requirements.pass.cpp | ||
---|---|---|
30 | In general, we want tests to be silent on success. |
test/std/containers/associative/set/insert_and_emplace_allocator_requirements.pass.cpp | ||
---|---|---|
30 | I'll see what I can do. The reason these tests are so noisy is because almost all of the assertions are in "container_test_types.h". Meaning that when the tests fail the diagnostic points into the header with no information about what code actually triggered the assertion. Hence why these tests manually print what they are testing. I'll try and come up with something better. |
I've silenced the tests when they pass as suggested. I added a 'assert_checkpoint.h' support header that stores the last checkpoint a test has passed and prints that information when std::abort is called.
I also moved the allocator requirement test templates into generic headers so the same version can be used by both the associative and unordered containers. Previously each test was duplicated.
In general, we want tests to be silent on success.