This is an archive of the discontinued LLVM Phabricator instance.

Differential D18611

Check alignment on the final value
ClosedPublic

Authored by • rafael on Mar 30 2016, 11:41 AM.

Details

Reviewers
atanasyan
Summary

I don't think this has any real word implications (unless something supports unaligned instructions), but unblocks simplifying the handling of PC relative relocations.

Diff Detail

Event Timeline

• rafael updated this revision to Diff 52094.Mar 30 2016, 11:41 AM
• rafael retitled this revision from to Check alignment on the final value.
• rafael updated this object.
• rafael added a reviewer: atanasyan.
• rafael added a subscriber: llvm-commits.
atanasyan accepted this revision.Mar 30 2016, 3:11 PM
atanasyan edited edge metadata.

LGTM

This revision is now accepted and ready to land.Mar 30 2016, 3:11 PM
atanasyan closed this revision.Apr 7 2016, 7:55 AM

Closed by commit rL265009.

Revision Contents

PathSize
ELF/
4 lines
test/
ELF/
Inputs/
2 lines
12 lines

Diff 52094

ELF/Target.cpp

Context not available.
uint64_t SA) { uint64_t SA) {
uint32_t Mask = 0xffffffff >> (32 - BSIZE); uint32_t Mask = 0xffffffff >> (32 - BSIZE);
uint32_t Instr = read32<E>(Loc); uint32_t Instr = read32<E>(Loc);
if (SHIFT > 0)
checkAlignment<(1 << SHIFT)>(SA, Type);
int64_t V = SA - P; int64_t V = SA - P;
if (SHIFT > 0)
checkAlignment<(1 << SHIFT)>(V, Type);
checkInt<BSIZE + SHIFT>(V, Type); checkInt<BSIZE + SHIFT>(V, Type);
write32<E>(Loc, (Instr & ~Mask) | ((V >> SHIFT) & Mask)); write32<E>(Loc, (Instr & ~Mask) | ((V >> SHIFT) & Mask));
} }
Context not available.

test/ELF/Inputs/mips-align-err.s

  • This file was added.
.global _foo
_foo:

test/ELF/mips-align-err.s

  • This file was added.
# REQUIRES: mips
# RUN: llvm-mc -filetype=obj -triple=mips-unknown-linux %s -o %t.o \
# RUN: -mcpu=mips32r6
# RUN: llvm-mc -filetype=obj -triple=mips-unknown-linux \
# RUN: -mcpu=mips32r6 %S/Inputs/mips-align-err.s -o %t2.o
# RUN: not ld.lld %t.o %t2.o -o %t.exe 2>&1 | FileCheck %s
# CHECK: improper alignment for relocation R_MIPS_PC16
.globl __start
__start:
.zero 1
beqc $5, $6, _foo # R_MIPS_PC16