This is an archive of the discontinued LLVM Phabricator instance.

Upgrade TBAA *before* upgrading intrinsics
ClosedPublic

Authored by beanz on Mar 16 2016, 2:52 PM.

Details

Summary

If TBAA is on an intrinsic and it gets upgraded and drops the TBAA we hit an odd assert. We should just upgrade the TBAA first because it doesn't have side-effects.

Diff Detail

Repository
rL LLVM

Event Timeline

beanz updated this revision to Diff 50877.Mar 16 2016, 2:52 PM
beanz retitled this revision from to Upgrade TBAA *before* upgrading intrinsics.
beanz updated this object.
beanz added reviewers: reames, apilipenko, manmanren.
beanz added a subscriber: llvm-commits.
reames edited edge metadata.Mar 16 2016, 3:26 PM

Confusing comment needs addressed, otherwise, looks straight forward. LGTM w/comment addressed.

lib/Bitcode/Reader/BitcodeReader.cpp
5337 ↗(On Diff #50877)

your comment makes this sound optional. Given this is fixing a bug, is that true?

This revision was automatically updated to reflect the committed changes.