This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] Remove localization tests for Russian month names
ClosedPublic

Authored by Hahnfeld on Mar 15 2016, 8:39 AM.

Details

Summary

Commit f49839299a085505eb673544744b61d2d9cdd1db in glibc-2.14 changed the locales to the currently required format. However, they were again changed in commit 55bdd2866f23b28422d969060b3518909a12b100 which has been released in 2.17.

That leads to the current situation where Debian and e.g. CentOS 6 have the pre-2.14 locales, for example Ubuntu 14.04 has pre-2.17 and CentOS 7 on the other hand has the newest locales in glibc-2.17.

Diff Detail

Repository
rL LLVM

Event Timeline

Hahnfeld updated this revision to Diff 50738.Mar 15 2016, 8:39 AM
Hahnfeld retitled this revision from to [libcxx] Remove localization tests for Russian month names.
Hahnfeld updated this object.
Hahnfeld added a reviewer: EricWF.
Hahnfeld added a subscriber: cfe-commits.
EricWF accepted this revision.Mar 15 2016, 8:53 AM
EricWF edited edge metadata.

It seems like we are not losing test coverage with these removals. And they have caused us a ton of pain.

I agree lets just get rid of them!

LGTM.

This revision is now accepted and ready to land.Mar 15 2016, 8:53 AM
This revision was automatically updated to reflect the committed changes.