This is an archive of the discontinued LLVM Phabricator instance.

Differential D18152

Fix dependency list of SLPVectorizer
ClosedPublic

Authored by yuyichao on Mar 14 2016, 10:33 AM.

Details

Reviewers
mssimpso
loladiro
Commits
rGa91ae8336baa: [SLPVectorizer] Fix dependency list
rL263476: [SLPVectorizer] Fix dependency list
Summary

I believe this is caused by R261212 (and various earlier version of it). Ref JuliaLang/julia#14998.

I'm happy to add test but couldn't find a suitable place or a similar test.

Diff Detail

Repository
rL LLVM

Event Timeline

yuyichao updated this revision to Diff 50615.Mar 14 2016, 10:33 AM
yuyichao retitled this revision from to Fix dependency list of SLPVectorizer.
yuyichao updated this object.
yuyichao added reviewers: loladiro, mssimpso.
yuyichao added a subscriber: llvm-commits.
Herald added a subscriber: mzolotukhin. · View Herald TranscriptMar 14 2016, 10:33 AM
mssimpso edited edge metadata.Mar 14 2016, 10:39 AM

Hi Yichao, thanks for catching this. LGTM.

mssimpso accepted this revision.Mar 14 2016, 10:40 AM
mssimpso edited edge metadata.
This revision is now accepted and ready to land.Mar 14 2016, 10:40 AM
Closed by commit rL263476: [SLPVectorizer] Fix dependency list (authored by kfischer). · Explain WhyMar 14 2016, 1:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
lib/
Transforms/
Vectorize/
1 line

Diff 50632

llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp

Show First 20 Lines • Show All 4,569 Lines • ▼ Show 20 Lines
char SLPVectorizer::ID = 0; char SLPVectorizer::ID = 0;
static const char lv_name[] = "SLP Vectorizer"; static const char lv_name[] = "SLP Vectorizer";
INITIALIZE_PASS_BEGIN(SLPVectorizer, SV_NAME, lv_name, false, false) INITIALIZE_PASS_BEGIN(SLPVectorizer, SV_NAME, lv_name, false, false)
INITIALIZE_PASS_DEPENDENCY(AAResultsWrapperPass) INITIALIZE_PASS_DEPENDENCY(AAResultsWrapperPass)
INITIALIZE_PASS_DEPENDENCY(TargetTransformInfoWrapperPass) INITIALIZE_PASS_DEPENDENCY(TargetTransformInfoWrapperPass)
INITIALIZE_PASS_DEPENDENCY(AssumptionCacheTracker) INITIALIZE_PASS_DEPENDENCY(AssumptionCacheTracker)
INITIALIZE_PASS_DEPENDENCY(ScalarEvolutionWrapperPass) INITIALIZE_PASS_DEPENDENCY(ScalarEvolutionWrapperPass)
INITIALIZE_PASS_DEPENDENCY(LoopSimplify) INITIALIZE_PASS_DEPENDENCY(LoopSimplify)
INITIALIZE_PASS_DEPENDENCY(DemandedBits)
INITIALIZE_PASS_END(SLPVectorizer, SV_NAME, lv_name, false, false) INITIALIZE_PASS_END(SLPVectorizer, SV_NAME, lv_name, false, false)
namespace llvm { namespace llvm {
Pass *createSLPVectorizerPass() { return new SLPVectorizer(); } Pass *createSLPVectorizerPass() { return new SLPVectorizer(); }
} }