This is an archive of the discontinued LLVM Phabricator instance.

Disable CFI checks in std::addressof.
ClosedPublic

Authored by eugenis on Mar 11 2016, 3:45 PM.

Download Raw Diff

Details

Reviewers

Summary

std::addressof may be used on a storage of an object before the start
of its lifetime (see std::allocate_shared for example). CFI flags the
C-style cast as invalid in that case.

Diff Detail

Repository: rL LLVM

Event Timeline

eugenis updated this revision to Diff 50495.Mar 11 2016, 3:45 PM

eugenis retitled this revision from to Disable CFI checks in std::addressof..

eugenis updated this object.

eugenis added a reviewer: EricWF.

eugenis set the repository for this revision to rL LLVM.

eugenis added a subscriber: cfe-commits.

LGTM.

This revision is now accepted and ready to land.Mar 11 2016, 3:46 PM

r263310
Thanks!

Revision Contents

Path

Size

include/

type_traits

2 lines

Diff 50495

include/type_traits

	Show First 20 Lines • Show All 393 Lines • ▼ Show 20 Lines

	#if _LIBCPP_STD_VER > 11			#if _LIBCPP_STD_VER > 11
	template <bool _Bp, class _Tp = void> using enable_if_t = typename enable_if<_Bp, _Tp>::type;			template <bool _Bp, class _Tp = void> using enable_if_t = typename enable_if<_Bp, _Tp>::type;
	#endif			#endif

	// addressof			// addressof

	template <class _Tp>			template <class _Tp>
	inline _LIBCPP_INLINE_VISIBILITY			inline _LIBCPP_NO_CFI _LIBCPP_INLINE_VISIBILITY
	_Tp*			_Tp*
	addressof(_Tp& __x) _NOEXCEPT			addressof(_Tp& __x) _NOEXCEPT
	{			{
	return (_Tp*)&reinterpret_cast<const volatile char&>(__x);			return (_Tp*)&reinterpret_cast<const volatile char&>(__x);
	}			}

	#if defined(_LIBCPP_HAS_OBJC_ARC) && !defined(_LIBCPP_PREDEFINED_OBJC_ARC_ADDRESSOF)			#if defined(_LIBCPP_HAS_OBJC_ARC) && !defined(_LIBCPP_PREDEFINED_OBJC_ARC_ADDRESSOF)
	// Objective-C++ Automatic Reference Counting uses qualified pointers			// Objective-C++ Automatic Reference Counting uses qualified pointers
	▲ Show 20 Lines • Show All 4,010 Lines • Show Last 20 Lines