This is an archive of the discontinued LLVM Phabricator instance.

fix cmake error when configuring libcxxabi
AbandonedPublic

Authored by sebpop on Mar 8 2016, 8:17 AM.

Details

Reviewers
mclow.lists
Summary

The problem occurs when configuring libcxxabi on x86_64 linux with:
$ cmake -DLLVM_PATH=$SRCTOP/llvm -DLIBCXXABI_LIBCXX_PATH=$SRCTOP/libcxx $SRCTOP/libcxxabi
[...]
CMake Error at llvm/cmake/modules/CheckCompilerVersion.cmake:31 (check_cxx_source_compiles):

Unknown CMake command "check_cxx_source_compiles".

Call Stack (most recent call first):

llvm/cmake/modules/HandleLLVMOptions.cmake:9 (include)
CMakeLists.txt:61 (include)

The fix is to include the cmake file that defines check_cxx_source_compiles.

Diff Detail

Repository
rL LLVM

Event Timeline

sebpop updated this revision to Diff 50044.Mar 8 2016, 8:17 AM
sebpop retitled this revision from to fix cmake error when configuring libcxxabi.
sebpop updated this object.
sebpop added reviewers: mclow.lists, EricWF.
sebpop set the repository for this revision to rL LLVM.
sebpop added a subscriber: llvm-commits.
mclow.lists edited edge metadata.EditedApr 13 2016, 9:01 AM

You're specifying -DLIBCXXABI_LIBCXX_PATH, but the Cmake bit that you're changing is inside of a elseif(NOT LLVM_ENABLE_LIBCXX) block.

Maybe I'm misunderstanding what's going on here (since my CMake-fu is close to nonexistent), but this seems wrong to me.

EricWF resigned from this revision.Apr 15 2016, 5:44 PM
EricWF removed a reviewer: EricWF.

This seems to have already been fixed. Sorry for the delay and thank you for the patch.

sebpop abandoned this revision.Jul 20 2016, 2:24 PM