This is an archive of the discontinued LLVM Phabricator instance.

[TSAN] Relax the expected output of race_on_mutex.c
ClosedPublic

Authored by slthakur on Mar 1 2016, 10:51 PM.

Details

Reviewers
dvyukov
samsonov
Summary

The stack trace produced by TSan on MIPS is:

  Previous write of size 8 at 0x0120ed2930 by thread T1:
    #0 memset
/home/slt/LLVM/llvm/projects/compiler-rt/lib/tsan/rtl/tsan_interceptors.cc:678
(race_on_mutex.c.tmp+0x0120071808)
    #1 __GI___pthread_mutex_init
/build/glibc-g99ldr/glibc-2.19/nptl/pthread_mutex_init.c:84
(libpthread.so.0+0x000000d634)
    #2 <null>
/home/slt/LLVM/llvm/projects/compiler-rt/test/tsan/race_on_mutex.c:11 (race_on_mutex.c.tmp+0x01200ea59c)

Diff Detail

Repository
rL LLVM

Event Timeline

slthakur updated this revision to Diff 49582.Mar 1 2016, 10:51 PM
slthakur retitled this revision from to [TSAN] Relax the expected output of race_on_mutex.c.
slthakur updated this object.
slthakur added reviewers: samsonov, dvyukov.
slthakur set the repository for this revision to rL LLVM.

Hi @samsonov, @dvyukov

Could you please find some time to review this?

dvyukov accepted this revision.Mar 16 2016, 5:54 AM
dvyukov edited edge metadata.

LGTM

This revision is now accepted and ready to land.Mar 16 2016, 5:54 AM
slthakur closed this revision.Mar 17 2016, 11:02 PM

Committed in revision 263778