This is an archive of the discontinued LLVM Phabricator instance.

[MSan] Mark dtls_test expected failure for MIPS
AbandonedPublic

Authored by mohit.bhakkad on Feb 26 2016, 4:54 AM.

Details

Summary

This test is failing with following report:

==4793==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0xfff51d13e0 in Thread1 llvm/projects/compiler-rt/test/msan/dtls_test.c:22:7
    #1 0xfff5149114 in MsanThreadStartFunc(void*) llvm/projects/compiler-rt/lib/msan/msan_interceptors.cc:1238
    #2 0xfff50a4cf4 in start_thread /build/glibc-g99ldr/glibc-2.19/nptl/pthread_create.c:311

Is it a known issue? I am unable to visit issue #44 because of transition of google code.

Diff Detail

Repository
rL LLVM

Event Timeline

mohit.bhakkad retitled this revision from to [MSan] Mark dtls_test expected failure for MIPS.
mohit.bhakkad updated this object.
mohit.bhakkad added reviewers: eugenis, samsonov, kcc.
mohit.bhakkad set the repository for this revision to rL LLVM.
mohit.bhakkad updated this object.
eugenis edited edge metadata.Feb 26 2016, 12:35 PM

Issue 44 is here: https://github.com/google/sanitizers/issues/547
And this failure shows that zero-initialized globals (.tbss) are not considered initialized by MSan, which is a bug somewhere in MSan TLS handling. See MsanThread::ClearShadowForThreadStackAndTLS.

test/msan/dtls_test.c
10

it's in dtls_test.c:22:7, isn't it?

mohit.bhakkad abandoned this revision.Feb 29 2016, 12:18 AM

Thanks,

I will update the link with a commit.
Looks like it was due to wrong kDtvOffset value for MIPS, corrected it in D17703.