This is an archive of the discontinued LLVM Phabricator instance.

Differential D17597

[LLDB][MIPS] Fix TestDisassembleBreakpoint
ClosedPublic

Authored by nitesh.jain on Feb 25 2016, 1:08 AM.

Details

Reviewers
clayborg
jaydeep
Commits
rG9b4ccee21b40: Merging r262819: --------------------------------------------------------------…
rG8f47909a8e2d: [LLDB][MIPS] Fix TestDisassembleBreakpoint
rLLDB262819: [LLDB][MIPS] Fix TestDisassembleBreakpoint
rL262819: [LLDB][MIPS] Fix TestDisassembleBreakpoint
Summary

The MIPS/MICROMIPS architecture will generate different jump instruction.

Diff Detail

Repository
rL LLVM

Event Timeline

nitesh.jain updated this revision to Diff 49021.Feb 25 2016, 1:08 AM
nitesh.jain retitled this revision from to [LLDB][MIPS] Fix TestDisassembleBreakpoint.
nitesh.jain updated this object.
nitesh.jain added a reviewer: clayborg.
nitesh.jain set the repository for this revision to rL LLVM.
nitesh.jain added subscribers: jaydeep, bhushan, slthakur and 2 others.
nitesh.jain added a reviewer: jaydeep.Feb 25 2016, 10:09 PM
jaydeep accepted this revision.Feb 29 2016, 9:03 PM
jaydeep edited edge metadata.

Looks good to me.

This revision is now accepted and ready to land.Feb 29 2016, 9:03 PM
clayborg accepted this revision.Mar 1 2016, 10:11 AM
clayborg edited edge metadata.
Closed by commit rL262819: [LLDB][MIPS] Fix TestDisassembleBreakpoint (authored by mohit.bhakkad). · Explain WhyMar 7 2016, 1:17 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lldb/
trunk/
packages/
Python/
lldbsuite/
test/
functionalities/
disassembly/
2 lines

Diff 49936

lldb/trunk/packages/Python/lldbsuite/test/functionalities/disassembly/TestDisassembleBreakpoint.py

Show All 36 Lines def test(self):
if arch in ["", 'x86_64', 'i386', 'i686']: if arch in ["", 'x86_64', 'i386', 'i686']:
breakpoint_opcodes = ["int3"] breakpoint_opcodes = ["int3"]
instructions = [' mov', ' addl ', 'ret'] instructions = [' mov', ' addl ', 'ret']
elif arch in ["arm", "aarch64"]: elif arch in ["arm", "aarch64"]:
breakpoint_opcodes = ["brk", "udf"] breakpoint_opcodes = ["brk", "udf"]
instructions = [' add ', ' ldr ', ' str '] instructions = [' add ', ' ldr ', ' str ']
elif re.match("mips" , arch): elif re.match("mips" , arch):
breakpoint_opcodes = ["break"] breakpoint_opcodes = ["break"]
instructions = ['lw', 'sw', 'jr'] instructions = ['lw', 'sw']
else: else:
# TODO please add your arch here # TODO please add your arch here
self.fail('unimplemented for arch = "{arch}"'.format(arch=self.getArchitecture())) self.fail('unimplemented for arch = "{arch}"'.format(arch=self.getArchitecture()))
# make sure that the software breakpoint has been removed # make sure that the software breakpoint has been removed
for op in breakpoint_opcodes: for op in breakpoint_opcodes:
self.assertFalse(op in disassembly) self.assertFalse(op in disassembly)
# make sure a few reasonable assembly instructions are here # make sure a few reasonable assembly instructions are here
self.expect(disassembly, exe=False, startstr = "a.out`sum", substrs = instructions) self.expect(disassembly, exe=False, startstr = "a.out`sum", substrs = instructions)