Add opencl.spir.version and opencl.ocl.version metadata for CodeGen to identify OpenCL version.
I was just wondering with SPIRV coming these days, how long should we be supporting and maintaining previous SPIR versions. Might be worth clarifying that...
|7022 ↗||(On Diff #49018)|
Could we please separate this from XCore code?
Add separate anonymous namespace for it and proper heading comment. See XCore above as an example.
Pls revise by Anastasia's comments. Otherwise LGTM.
We have two options about SPIR-V support:
- drop SPIR support and move on to SPIR-V
- keep supporting both SPIR and SPIR-V
Option 1 is cleaner and easier to maintain, however it will require changes in backends which expect SPIR format for OCL programs.
|7211 ↗||(On Diff #49136)|
Could you change the comment please to something more specific. For example:
|7214 ↗||(On Diff #49136)|
|15 ↗||(On Diff #49136)|
Forgotten to check OpenCL version here?