Page MenuHomePhabricator

[NVPTX] Update address space mapping documentation
AbandonedPublic

Authored by rivanvx on Feb 10 2016, 5:21 AM.

Details

Reviewers
jingyue
Summary

Current address space mapping documentation does not match the
PTXLdStInstCode::AddressSpace enum defined in lib/Target/NVPTX/NVPTX.h.
This patch updates documentation accordingly.

Diff Detail

Event Timeline

rivanvx updated this revision to Diff 47445.Feb 10 2016, 5:21 AM
rivanvx retitled this revision from to [NVPTX] Update address space mapping documentation.
rivanvx updated this object.
rivanvx added a reviewer: jingyue.

The documentation is actually correct here. PTXLdStInstCode is an internal enumeration that is independent of the public address space mapping. It's unfortunate that there is disagreement between the two mappings, but this should be fixed by changing the PTXLdStInstCode enum. See the AddressSpace enum in lib/Target/NVPTX/MCTargetDesc/NVPTXBaseInfo.h.

rivanvx abandoned this revision.Feb 10 2016, 8:05 AM

I see. Thanks for the info.