This is an archive of the discontinued LLVM Phabricator instance.

[GCC] GOMP_task: Change argument type of if_cond from int to bool
ClosedPublic

Authored by Hahnfeld on Feb 5 2016, 4:55 AM.

Details

Summary

(libgomp has bool as well)

This was causing a test failure in omp_test_if.c when building with GCC in Debug mode. I have verified that GCC versions 4.9.2 and 5.3.0 now work and compile-tested this change with clang 3.7.1 and Intel Compiler 16.0.

Diff Detail

Repository
rL LLVM

Event Timeline

Hahnfeld updated this revision to Diff 47010.Feb 5 2016, 4:55 AM
Hahnfeld retitled this revision from to [GCC] GOMP_task: Change argument type of if_cond from int to bool.
Hahnfeld updated this object.
Hahnfeld added reviewers: jlpeyton, AndreyChurbanov.
Hahnfeld added a subscriber: openmp-commits.
AndreyChurbanov accepted this revision.Feb 5 2016, 9:06 AM
AndreyChurbanov edited edge metadata.

LGTM

This revision is now accepted and ready to land.Feb 5 2016, 9:06 AM
This revision was automatically updated to reflect the committed changes.