This is an archive of the discontinued LLVM Phabricator instance.

[RS4GC] Pass DenseMap by reference, NFC
ClosedPublic

Authored by JosephTremoulet on Feb 4 2016, 5:39 PM.

Reviewers

reames
sanjoy

Commits

Summary

Passing the rematerialized values map to insertRematerializationStores by
value looks to be a simple oversight; update it to pass by reference.

JosephTremoulet retitled this revision from to [RS4GC] Pass DenseMap by reference, NFC.

JosephTremoulet updated this object.

sanjoy edited edge metadata.

This revision is now accepted and ready to land.Feb 4 2016, 5:45 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

trunk/

lib/

Transforms/

Scalar/

9 lines

	Show First 20 Lines • Show All 1,611 Lines • ▼ Show 20 Lines
	#ifndef NDEBUG			#ifndef NDEBUG
	VisitedLiveValues.insert(OriginalValue);			VisitedLiveValues.insert(OriginalValue);
	#endif			#endif
	}			}
	}			}

	// Helper function for the "relocationViaAlloca". Similar to the			// Helper function for the "relocationViaAlloca". Similar to the
	// "insertRelocationStores" but works for rematerialized values.			// "insertRelocationStores" but works for rematerialized values.
	static void			static void insertRematerializationStores(
	insertRematerializationStores(			const RematerializedValueMapTy &RematerializedValues,
	RematerializedValueMapTy RematerializedValues,
	DenseMap<Value , Value > &AllocaMap,			DenseMap<Value , Value > &AllocaMap,
	DenseSet<Value *> &VisitedLiveValues) {			DenseSet<Value *> &VisitedLiveValues) {

	for (auto RematerializedValuePair: RematerializedValues) {			for (auto RematerializedValuePair: RematerializedValues) {
	Instruction *RematerializedValue = RematerializedValuePair.first;			Instruction *RematerializedValue = RematerializedValuePair.first;
	Value *OriginalValue = RematerializedValuePair.second;			Value *OriginalValue = RematerializedValuePair.second;

	assert(AllocaMap.count(OriginalValue) &&			assert(AllocaMap.count(OriginalValue) &&
	"Can not find alloca for rematerialized value");			"Can not find alloca for rematerialized value");
	Value *Alloca = AllocaMap[OriginalValue];			Value *Alloca = AllocaMap[OriginalValue];
	▲ Show 20 Lines • Show All 1,227 Lines • Show Last 20 Lines