This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] Change in initial size of DSAStackTy::StackTy
ClosedPublic

Authored by esakella on Feb 2 2016, 3:29 AM.

Details

Summary

Hello,

I have made a small change in the initial size of the StackTy SmallVector of class DSAStackTy.

I reduced the initial size of this SmallVector from 64 elements to 4 elements, in order to improve the memory consumption during the creation of the Sema, whose constructor calls the Sema::InitDataSharingAttributesStack() function, which in turn creates a DSAStackTy.

After profiling Clang (I just gave it a simple source file to compile) before and after this change, the difference in memory consumption is up to almost 400 KB.

Would that change be acceptable?

Thank you,
Sakellari Elisavet

Diff Detail

Event Timeline

esakella updated this revision to Diff 46633.Feb 2 2016, 3:29 AM
esakella retitled this revision from to [OpenMP] Change in initial size of DSAStackTy::StackTy.
esakella updated this object.
esakella added a reviewer: ABataev.
esakella added a subscriber: ABataev.
esakella removed a subscriber: ABataev.
ABataev accepted this revision.Feb 2 2016, 8:28 PM
ABataev edited edge metadata.

LG. Will you commit it yourself or you want me to do this?

This revision is now accepted and ready to land.Feb 2 2016, 8:29 PM
karies closed this revision.Feb 3 2016, 2:50 AM
karies added a subscriber: karies.

Committed as r259637