This is an archive of the discontinued LLVM Phabricator instance.

Differential D16750

Bug 15685 - OpenCL 'char' is not signed
AbandonedPublic

Authored by • ichesnokov on Jan 30 2016, 8:58 AM.

Details

Reviewers
None
Summary

A simple patch to ensure that char is signed. Check assumed for OpenCL only.

Diff Detail

Repository
rL LLVM

Event Timeline

• ichesnokov updated this revision to Diff 46474.Jan 30 2016, 8:58 AM
• ichesnokov retitled this revision from to Bug 15685 - OpenCL 'char' is not signed.
• ichesnokov updated this object.
• ichesnokov added reviewers: asl, kraiskil.
• ichesnokov set the repository for this revision to rL LLVM.
• ichesnokov added a subscriber: cfe-commits.

Please review and commit.

• ichesnokov added a comment.Jan 30 2016, 9:02 AM

BugZilla page: https://llvm.org/bugs/show_bug.cgi?id=15685

• ichesnokov abandoned this revision.Jan 30 2016, 9:51 AM
• ichesnokov removed reviewers: kraiskil, asl.
• ichesnokov removed a subscriber: cfe-commits.

Revision Contents

PathSize
test/
SemaOpenCL/
ocl-char-is-not-signed.cl
ocl-char-is-not-signed.cl (nonexistent)
3 lines

Diff 46474

test/SemaOpenCL/ocl-char-is-not-signed.cl

// RUN: %clang_cc1 %s
constant int CHECK = (char)(0xFFu) < 0 ? 0 : 1/0;